25104 - Skinnable Common Dialogs

Status: VERIFIED FIXED

(SeaMonkey :: Passwords & Permissions, defect, P3)

Description

[kevinyen]

UI polish is the #4 beta priority, ahead of features, and based on feedback from 
several people, we need to fix the input boxes on the two dialogues that ask for 
key to the db.

Steve and I discussed this this morning.  The fixes may be done already, but I'm 
filing a bug for tracking this.

Basically, the fixes are:
1. On the dual input field dialog box that asks for the key:  align and shorten 
the input boxes
2. On the single input field box: short the input box.

thx,
kevin

Comment 1

[Stephen P. Morse]

None if this is possible with the current implementation of dialogs.  All the 
caller of the dialogs can do is specify the messages preceding the input boxes 
and the number of input boxes.  There is no control over the positioning and 
widths of those boxes.

I could do an ad-hoc fix for the alignment problem by padding the message 
preceding the first input box so that it is the same length as the second 
message.  That would cause the two input boxes to align.  But it would be 
language-dependent -- it wouldn't work in japanese.  There is no fix, ad-hoc or 
otherwise that I can make in the wallet/single-signon code to shorten the width 
of the text fields.

Of more concern to me is the fact that the input boxes have up-arrow buttons on 
the right end.  These arrows are meaningless.  But that too the caller has no 
control over.

So any fix would involve a change in the dialog routines themselves.  
Reassigning to Don since dialogs are in his team. 

Comment 2

[don]

OK, Ben sez he has the time to fix this for Beta 1 ...

Comment 3

[Stephen P. Morse]

Somebody's been changing this in the past two days and the dialog is now 
unacceptable (previously I would have classified this as a nuisance bug).  
Here's what's regressed:

1. The "user name" label is now wrapping to two lines
2. The OK/Cancel buttons are being chopped off at the bottom
3. The text for the checkbox is supposed to say "Save these values".  Instead it 
is saying "check".

Items 1 and 2 are tidy-appearance items.  Item 3 is an outright bug.

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

M15 now...

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

this is just weird. the text fields are picking heights out of the air. evaughan 
looked at this and was similarly confused. 

can't really line things up nicely w/o a springgrid. pushing back... 

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

These dialogs are unskinnable and look absolutely awful. I should fix them for 
beta2 so we don't look silly ;) 

Comment 7

[Stephen P. Morse]

No longer a problem for wallet/ single-signon dialogs because the master 
password functions (and hence these dialogs) have been removed -- they will be 
handled by PSM with whatever UI PSM will be providing.

But I take it that this bug report is now dealing with more than just 
wallet/single-signon's dialogs so I'll not close it out.  But it is no longer an 
issue for me.

Comment 8

[leger]

PDT needs info, what else is left to be done here?  Are other areas ok now too?

Comment 9

[Peter Trudelle]

[nsbeta2-]

Comment 10

[don]

Move to M20 target milestone.

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

fixed. 

Comment 12

[sairuh (rarely reading bugmail)]

vrfy for the cases for autofill and sso.