251233 - port bug 120525 fix for classic theme to FireFox

Status: RESOLVED WORKSFORME

(Toolkit :: Themes, defect)

Description

[:deanis74]

There's a few simple theme changes in there for the focus rectangle on buttons
in Windows.

Comment 1

[:deanis74]

File to update is toolkit/themes/winstripe/global/button.css.

Comment 2

[Bill Mason]

I think you've cited the wrong bug number for the Seamonkey bug.

Comment 3

[Ryan Polk (Quark)]

Attachment: straight port of final patch

This is my first attempt at posting a patch, and is a straight port of the
patch from bug 120525.	Note the summary erronously points to bug 150525.

Original version of button.css taken from aviary, not trunk (I know you can
tell by the diff, but I'm new at this).

Comment 4

[Ryan Polk (Quark)]

Comment on attachment 153060 [details] [diff] [review]
straight port of final patch

Simple port, hopefully I wrote the file right.

Comment 5

[:deanis74]

Looks good to me.  Mike, think this can make it in?

Comment 6

[Mike Connor [:mconnor]]

I think we might want to tweak this for GNOME too, last time I saw a side by
side screenshot it was wrong in a similar fashion.

same URL, just gnomestripe instead of winstripe.

I'll defer judgement until the morning.  I've been up too long to trust my
judgement :)

Comment 7

[Ryan Polk (Quark)]

Attachment: gnomestripe and winstripe

both files together, diff taken slightly differently to get the directories
right

Comment 8

[Ryan Polk (Quark)]

Comment on attachment 153193 [details] [diff] [review]
gnomestripe and winstripe

since mconner said he'll look

Comment 9

[Ryan Polk (Quark)]

Comment on attachment 153193 [details] [diff] [review]
gnomestripe and winstripe

(sorry about the bugspam, fixing field)

Comment 10

[Ryan Polk (Quark)]

Note to self: this is in /toolkit, so check if Qute needs it for Thunderbird.

Comment 11

[Ryan Polk (Quark)]

Attachment: w/ qute

Gnomestripe, Winstripe, and Qute (for Thunderbird).

Comment 12

[Mike Connor [:mconnor]]

Comment on attachment 160115 [details] [diff] [review]
w/ qute

to kmgerich, if this looks good, land with rs=me :)

Comment 13

[Phil Ringnalda (:philor)]

Comment on attachment 160115 [details] [diff] [review]
w/ qute

You have to look at this patch sort of sideways to review it, since it's old enough to have still needed to patch Qute :)

Comment 14

[Dão Gottwald [:dao]]

Comment on attachment 160115 [details] [diff] [review]
w/ qute

It's not clear to me that the current focus ring has the wrong size. I'd like to see some screenshots (before, after, native apps for comparison) and of course a patch that actually applies.

Comment 15

[Phil Ringnalda (:philor)]

Fortunately, this was Ryan's first, but not his only bug, that would have been kinda sad.

Comment 16

[Tim Nguyen :ntim]

This is pretty old, is it still relevant ?