251260 - X10-style XBM images do not render properly

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Aaron Kaluszka]

XBM images using the X10-style C code (an array of shorts instead of the
X11-style array of chars) does not render properly because the values are always
assumed to be chars.

Comment 1

[Aaron Kaluszka]

Attachment: Patch

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 153074 [details] [diff] [review]
Patch

(hmm, that file needs more error checking...)

+	     return NS_OK;

please add a comment like "Waiting for more data"

+	     if(!mIsX10 || !hiByte)

style of this file is a space between if and '('
(3 times in this patch)


I'd like tor to sr this patch

Comment 3

[tor]

Comment on attachment 153074 [details] [diff] [review]
Patch

>+                if(hiByte) pixel >>= 8;

Along with the changes biesi requested, split this into two lines.
sr=tor

Comment 4

[Aaron Kaluszka]

Attachment: Patch, nits fixed

I don't have CVS access, so somebody else will have to check this in...

Comment 5

[Aaron Kaluszka]

Attachment: Patch for this and bug 251446

Comment 6

[tor]

Comment on attachment 153242 [details] [diff] [review]
Patch for this and bug 251446

Do not combine changes.  sr-

Comment 7

[Aaron Kaluszka]

Sorry, I didn't think 2 lines warranted an entire extra patch...

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 153242 [details] [diff] [review]
Patch for this and bug 251446

yes, please make a new patch for that bug

Comment 9

[Aaron Kaluszka]

tor or biesi, can you check in patch 153174?

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in, sorry for the delay :(