Firefox help not keyboard accessible

RESOLVED FIXED

Status

SeaMonkey
Help Viewer
RESOLVED FIXED
14 years ago
2 years ago

People

(Reporter: Aaron Leventhal, Assigned: Aaron Leventhal)

Tracking

(Blocks: 1 bug, {access, sec508})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

14 years ago
This is a follow up for bug 241469, which made seamonkey help keyboard accessible.

Firefox needs close to the same patch.
(Assignee)

Comment 1

14 years ago
Created attachment 153157 [details] [diff] [review]
Couldn't test because of other firefox build problems related to help

Notes:
* Also fixes the equivalent of bug 200127 for firefox.
* Changes to pinstripe's filepicker.css appear strange because CVS thinks it's
a binary file. All the changes to that file do is remove the unneeded focus
rules.
* Couldn't test because of this error, which I was getting even before I
applied the patch, with a fresh tree:
This message appears below the status bar when I run firefox <key
id="key_openHelp" keycode="&openHelp.commandkey;"
Also, the help menu isn't getting populated which prevents me from testing the
patch. Perhaps it's not finding the correct dtd?
Again, unrelated to this patch. Anyone know what's up?
(Assignee)

Comment 2

14 years ago
Timeless says that
cvs admin -k t 
can fix the filepicker.css to be a text file.
(Assignee)

Updated

14 years ago
Attachment #153157 - Flags: review?(rlk)

Updated

14 years ago
Component: Help Documentation → Help Viewer
QA Contact: firefox.help-documentation → firefox.help
(Assignee)

Comment 3

14 years ago
Created attachment 153426 [details] [diff] [review]
New patch that can be applied - filepicker.css is a text file now
Attachment #153157 - Attachment is obsolete: true
(Assignee)

Comment 4

14 years ago
Comment on attachment 153426 [details] [diff] [review]
New patch that can be applied - filepicker.css is a text file now

Tested, it doesn't fix all the problems.
Attachment #153426 - Attachment is obsolete: true
(Assignee)

Updated

14 years ago
Attachment #153157 - Flags: review?(rlk)
(Assignee)

Comment 5

14 years ago
Created attachment 153517 [details] [diff] [review]
Same fix in firefox as used for Seamonkey. Tested, works.
(Assignee)

Updated

14 years ago
Attachment #153517 - Flags: review?(rlk)

Comment 6

14 years ago
Aaron: your patch won't apply. Can you make sure your patch is using the latest
code?
(Assignee)

Comment 7

14 years ago
Created attachment 153673 [details] [diff] [review]
Tested patch for aviary
(Assignee)

Updated

14 years ago
Attachment #153673 - Flags: review?(rlk)

Comment 8

14 years ago
Comment on attachment 153673 [details] [diff] [review]
Tested patch for aviary

aaronlev, I applied your patch but don't see anything changed when I run the
build. Might be a problem with my tree. Going to ask mconnor to take a look at
it.
Attachment #153673 - Flags: review?(rlk) → review?(mconnor)
(Assignee)

Comment 9

14 years ago
Works for me when I build aviary. 

1. I can press Alt+ an underlined letter to bring up the appropriate panel
2. I can type Ctrl+Tab or Ctrl+Shift+Tab to cycle through panels
3. When I'm in a panel with a list or tree view I can down arrow into the panel
and make a selection.

How do your results differ?

(In reply to comment #8)
> (From update of attachment 153673 [details] [diff] [review])
> aaronlev, I applied your patch but don't see anything changed when I run the
> build. Might be a problem with my tree. Going to ask mconnor to take a look at
> it.
> 

(Assignee)

Comment 10

14 years ago
Comment on attachment 153673 [details] [diff] [review]
Tested patch for aviary

I've tested this on aviary and it does have the desired effect.
Attachment #153673 - Attachment description: Untested patch for aviary → Tested patch for aviary

Updated

14 years ago
Attachment #153673 - Flags: review?(mconnor) → review+

Comment 11

14 years ago
Fix checked in.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
(Assignee)

Comment 12

14 years ago
Note this is only in aviary until rlk moves all the updated help stuff to the
firefox trunk.

Updated

14 years ago
Attachment #153517 - Flags: review?(rlk)

Comment 13

14 years ago
Did this check in cause Bug 255516 ?

Updated

13 years ago
Component: Help Viewer → Help Viewer
Flags: review+
Product: Firefox → Toolkit
Product: Toolkit → Seamonkey
You need to log in before you can comment on or make changes to this bug.