This is a follow up for bug 241469, which made seamonkey help keyboard accessible. Firefox needs close to the same patch.
Created attachment 153157 [details] [diff] [review] Couldn't test because of other firefox build problems related to help Notes: * Also fixes the equivalent of bug 200127 for firefox. * Changes to pinstripe's filepicker.css appear strange because CVS thinks it's a binary file. All the changes to that file do is remove the unneeded focus rules. * Couldn't test because of this error, which I was getting even before I applied the patch, with a fresh tree: This message appears below the status bar when I run firefox <key id="key_openHelp" keycode="&openHelp.commandkey;" Also, the help menu isn't getting populated which prevents me from testing the patch. Perhaps it's not finding the correct dtd? Again, unrelated to this patch. Anyone know what's up?
Timeless says that cvs admin -k t can fix the filepicker.css to be a text file.
Component: Help Documentation → Help Viewer
QA Contact: firefox.help-documentation → firefox.help
Created attachment 153426 [details] [diff] [review] New patch that can be applied - filepicker.css is a text file now
Attachment #153157 - Attachment is obsolete: true
Comment on attachment 153426 [details] [diff] [review] New patch that can be applied - filepicker.css is a text file now Tested, it doesn't fix all the problems.
Attachment #153426 - Attachment is obsolete: true
Created attachment 153517 [details] [diff] [review] Same fix in firefox as used for Seamonkey. Tested, works.
Aaron: your patch won't apply. Can you make sure your patch is using the latest code?
Comment on attachment 153673 [details] [diff] [review] Tested patch for aviary aaronlev, I applied your patch but don't see anything changed when I run the build. Might be a problem with my tree. Going to ask mconnor to take a look at it.
Attachment #153673 - Flags: review?(rlk) → review?(mconnor)
Works for me when I build aviary. 1. I can press Alt+ an underlined letter to bring up the appropriate panel 2. I can type Ctrl+Tab or Ctrl+Shift+Tab to cycle through panels 3. When I'm in a panel with a list or tree view I can down arrow into the panel and make a selection. How do your results differ? (In reply to comment #8) > (From update of attachment 153673 [details] [diff] [review]) > aaronlev, I applied your patch but don't see anything changed when I run the > build. Might be a problem with my tree. Going to ask mconnor to take a look at > it. >
Comment on attachment 153673 [details] [diff] [review] Tested patch for aviary I've tested this on aviary and it does have the desired effect.
Attachment #153673 - Attachment description: Untested patch for aviary → Tested patch for aviary
Fix checked in.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Note this is only in aviary until rlk moves all the updated help stuff to the firefox trunk.
Did this check in cause Bug 255516 ?
Component: Help Viewer → Help Viewer
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.