251548 - Minor nits and cruft removal from composer_help.xhtml

Status: RESOLVED FIXED

(Documentation Graveyard :: Help Viewer, defect)

Description

[Hendrik Maryns]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; nl-NL; rv:1.7.1) Gecko/20040707
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; nl-NL; rv:1.7.1) Gecko/20040707

In the Section "Setting Page Colors and Background", under the third list item
'Use custom colors', it says: "For each element, select a color from the
drop-down list."  But there is no drop-down list there, it is a colored button
which opens a window where you can choose a color.

I'm using the Dutch version, but I have the English documentation too (for
translation help), so I guess the problem occurs there too.

Reproducible: Always
Steps to Reproduce:
see above

Comment 1

[Giacomo Magnini]

Will be fixed if and when the patch in bug 262080 will be checked in.

Comment 2

[Gérard Talbot]

Good catch, Hnedrik! If you find others like that, drop a comment in bug 262080.
That "Create Web Pages" helpfile section was last edited (updated?) on 20 June 2002.

Setting dependency.

Comment 3

[Hendrik Maryns]

Thanks!  I'm re-editing the Dutch version, that's how I noticed.  So indeed you
can expect more...

Comment 4

[Giacomo Magnini]

Attachment: Fix reported nit, plus cruft removal

Comment 5

[Gérard Talbot]

+<a href="http://http://www.visibone.com/colorlab/" target="_blank">here</a>.</li>
1- Link is wrong (extra http://) 2- visibone.com is a commercial site: so, no
money, no color code converter. I just think we should remove the link until we
find a free and recommendable color code converter page easy to use.

Comment 6

[Gérard Talbot]

Still not a color code converter, but this link is safe and recommendable:

CSS 2.1 keyword color names:
http://www.w3.org/TR/CSS21/syndata.html#color-units

Comment 7

[Giacomo Magnini]

Attachment: More cruft removal, &apos; and <q> added to the pack

Comment 8

[Giacomo Magnini]

(In reply to comment #5)
> +<a href="http://http://www.visibone.com/colorlab/" target="_blank">here</a>.</li>
> 1- Link is wrong (extra http://) 2- visibone.com is a commercial site: so, no
> money, no color code converter. I just think we should remove the link until we
> find a free and recommendable color code converter page easy to use.

Link is wrong (thanks), but if you click on a color, it will give you the right
codes. Plus, it's multilingual. You don't have to pay to get the right color
codes, but I'm open to better suggestions. W3C link is too limited IMHO.

Comment 9

[Giacomo Magnini]

What about these?
http://www.nutrocker.co.uk/colorchart.html
http://www.lissaexplains.com/color2.shtml
http://www.alterlinks.com/goodies/colors.php (doesn't work with mozilla!)
Anything else?

Comment 10

[Gérard Talbot]

> http://www.nutrocker.co.uk/colorchart.html
will only work with javascript ON

> http://www.lissaexplains.com/color2.shtml
requires java, just like http://www.1stsitefree.com/rgb_hex.htm

> http://www.alterlinks.com/goodies/colors.php (doesn't work with mozilla!)
> Anything else?

http://www.w3schools.com/html/html_colornames.asp (not java nor javascript needed)
even though there are problems with such file: only 17 css (CSS 2.1) color names
are allowed; in HTML 4.01, it's only 16 for transitional HTML 4.01
http://www.w3.org/TR/html4/types.html#h-6.5
MSIE 5+, NS 6+ and Mozilla will honor these 216 web safe color names but some
other browsers might not as they are not obliged in any way to support more than
17 color names. 

Comment 11

[Gérard Talbot]

> MSIE 5+, NS 6+ and Mozilla will honor these 216 web safe color names but some
> other browsers might not as they are not obliged in any way to support more than
> 17 color names. 

This was also discussed in bug 142488

If you mention the CSS 2.1 keyword (17) color names link
http://www.w3.org/TR/CSS21/syndata.html#color-units
along with the 
http://www.w3schools.com/html/html_colornames.asp
then it's ok with me as both files underline that only 16 HTML color names are
the W3C web standard for now.

Comment 12

[Stefan [:stefanh]]

Comment on attachment 161188 [details] [diff] [review]
More cruft removal, &apos; and <q> added to the pack

Since there's "&quote;" and not <q> in all the other files I presume you'll
change the other files as well? BTW, why using <q> instead of "quote;" (unless
you have a plan for styling all the quotes, of course)?

Comment 13

[Giacomo Magnini]

(In reply to comment #12)
> (From update of attachment 161188 [details] [diff] [review])
> Since there's "&quote;" and not <q> in all the other files I presume you'll
> change the other files as well? BTW, why using <q> instead of "quote;" (unless
> you have a plan for styling all the quotes, of course)?

Not in all other files: one has <q> as well, or at least some of them
(mail_help.xhtml maybe?). Yes, I would like to change them all for 2 reasons:
1) <q></q> is shorter than &quot;&quot;
2) if anybody (embedders or other vendors) want to differentiate from mozilla
docs, they can easily style quotes.
If you or Neil don't agree, I can easily revert the change, but I think it's
worth the pain...

Comment 14

[Stefan [:stefanh]]

> 1) <q></q> is shorter than &quot;&quot;
> 2) if anybody (embedders or other vendors) want to differentiate from mozilla
> docs, they can easily style quotes.

Sounds reasonable to me. However, Neil is the person in charge for Help - I'm 
not a peer, you know ;)

Comment 15

[[e-mail]]

Apart from the link issues discussed I'm happy with the patch, but next time
could you not mix automated changes with manual changes? That way, I don't have
to wade though a load of <strong> changes to find the real change :-)

Comment 16

[Giacomo Magnini]

Sorry for embedding that small change in such a major clean up. Won't do that
again, I promise! :) Anyway, what's your opinion about <q> vs. &quot; ?

Comment 17

[Giacomo Magnini]

Attachment: Updated patch with external links fixed as suggested

Here we go. I have added both links suggested by Daniel to the pack.

Comment 18

[Ian Neal]

Comment on attachment 163117 [details] [diff] [review]
Updated patch with external links fixed as suggested

r=[e-mail]

<q></q> is fine by me

Comment 19

[Ian Neal]

Checking in en-US/composer_help.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/composer_help.xhtml,v 
<--  composer_help.xhtml
new revision: 1.24; previous revision: 1.23
done

Just a note that I had problems because the diff had been hand editted incorrectly.
One hunk said:
@@ -361,56 +359,55 @@ Press Shift+Tab to outdent one level.</p
instead of:
@@ -361,56 +359,57 @@ Press Shift+Tab to outdent one level.</p

Comment 20

[Stefan [:stefanh]]

--> Fixed.