251749 - use initializers for ShortcutResolver::ShortcutResolver() and nsLocalFile::nsLocalFile() and clobber mFileInfo64

Status: RESOLVED DUPLICATE of bug 237094

(Core :: XPCOM, enhancement)

Description

[timeless]

Comment 1

[timeless]

Attachment: changes

Comment 2

[Darin Fisher]

Comment on attachment 153424 [details] [diff] [review]
changes

>Index: nsLocalFileWin.cpp

> ShortcutResolver::ShortcutResolver()
>+:   mLock(nsnull),
>+    mPersistFile(nsnull),
>+    mShellLink(nsnull)

> nsLocalFile::nsLocalFile()
>+ :  mFollowSymlinks(PR_FALSE)

nit: please be consistent in your use of whitespace.


>     MakeDirty();
>+    memset(&mFileInfo64,0,sizeof mFileInfo64);

nit: please use whitespace between arguments to a function.

also, i prefer |sizeof(mFileInfo64)|.  it is more consistent with existing
coding conventions in xpcom/io.


r+sr=darin with these nits picked.

Comment 3

[timeless]

*** This bug has been marked as a duplicate of 237094 ***