Closed
Bug 251749
Opened 20 years ago
Closed 20 years ago
use initializers for ShortcutResolver::ShortcutResolver() and nsLocalFile::nsLocalFile() and clobber mFileInfo64
Categories
(Core :: XPCOM, enhancement)
Tracking
()
RESOLVED
DUPLICATE
of bug 237094
People
(Reporter: timeless, Assigned: timeless)
Details
Attachments
(1 file)
885 bytes,
patch
|
darin.moz
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
Attachment #153424 -
Flags: superreview?(darin)
Attachment #153424 -
Flags: review?(darin)
Comment 2•20 years ago
|
||
Comment on attachment 153424 [details] [diff] [review] changes >Index: nsLocalFileWin.cpp > ShortcutResolver::ShortcutResolver() >+: mLock(nsnull), >+ mPersistFile(nsnull), >+ mShellLink(nsnull) > nsLocalFile::nsLocalFile() >+ : mFollowSymlinks(PR_FALSE) nit: please be consistent in your use of whitespace. > MakeDirty(); >+ memset(&mFileInfo64,0,sizeof mFileInfo64); nit: please use whitespace between arguments to a function. also, i prefer |sizeof(mFileInfo64)|. it is more consistent with existing coding conventions in xpcom/io. r+sr=darin with these nits picked.
Attachment #153424 -
Flags: superreview?(darin)
Attachment #153424 -
Flags: superreview+
Attachment #153424 -
Flags: review?(darin)
Attachment #153424 -
Flags: review+
*** This bug has been marked as a duplicate of 237094 ***
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•