251771 - Can't display multiple events properly [dayview/weekview layout]

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Hadmut Danisch]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040707 Debian/1.7-5
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040707 Debian/1.7-5

Hi,

see the given IETF calender, e.g. go to Aug 02 2004. 
Calendar has obviously problems with displaying several 
concurrent events properly. 

regards
Hadmut


Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Martin Bagge / brother]

Attachment: Dayview showing the problem

Comment 2

[Martin Bagge / brother]

Attachment: Weekview of the problem

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: testcase

Attached testcase shows the problem.
The 'B' event should be wider.

Comment 4

[Matthew (lilmatt) Willis]

Attachment: Screenshot of the attachment 163977 (testcase) imported into Apple iCal 1.5.2

Comment 5

[Matthew (lilmatt) Willis]

Attachment: Screenshot of the URL in Apple iCal 1.5.2

Comment 6

[Michael Nacey]

Confirmed at TB 1.0/Calendar 2005-1-11

Comment 7

[gekacheka]

Attachment: test case: 2 events, 3 events, 2 events, 4 events

Comment 8

[gekacheka]

Attachment: calendarWindow.setDrawProperties patch: fix ended rows of group when slot added

(patch -l -p 2 -i file.patch)

Fixes layout of concurrent events in day view and week view for example test
cases.	

Tested on 0.2 branch calendar on TB1.0 (faster than Moz1.7.5).
Can test on trunk after nightly build is available.

Details:

compareDisplayEventStart:  when starts are event, compare ends so longer events
will be to the left of short events, to reduce space fragmentation caused when
long event column appears between two short event columns.

setEventBoxClass: escape " as \" for better emacs view.

setDrawProperties:
o Move loop control expressions to top (clarify loop)
o Bind frequent array accesses to named var (clarify).
o Each contiguous overlapping group starts with 0 column slots.
  Slots are added as needed as concurrent events are added.
  As events end, slots are opened.  New events fill all continguous
  open slots available.  If no open slots are available,
  an existing event that occupies multiple slots can be shrunk.
  - One problem was that the old algorithm didn't set the 
    event.startDrawSlot when taking slots from previous event.
  - Another problem was that it allocated the slot at the
    end of a block of slots, so that events at the same time
    appeared in reverse order.
  Therefore, now previous event only keeps first of multiple
  slots, and new event takes rest of the column slots.	
  Any later same-time events must take columns afterward, so
  they appear in same order as data source (order added to file).
o The last event in a row fills all the columns available.
  But if a later row in the same group has more elements, then 
  the previous row no longer fills all the columns of the group.
  Therefore, when adding a new column slot, Now look for events at 
  end of previous rows (ended and occupied previous last column)
  and make them wider to occupy the new column.

Comment 9

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 172065 [details] [diff] [review]
calendarWindow.setDrawProperties patch: fix ended rows of group when slot added

With this patch, the testcase looks much better.
(I know this are the old views, but we are very likely going to port this code
to the new views. No need to reinvent this part)
r=mvl

Comment 10

[Michiel van Leeuwen (email: mvl+moz@)]

Patch checked in. (updated to trunk first)
My oringinal testcase was the ietf file. That displays ok. The other testcase
(attachment 163977 [details]) still fails though, but i checked in anyway, because of the
huge improvement.
Leaving open for the remaining issue.

Comment 11

[gekacheka]

Attachment: Fix conversion bug: '<' --> '<='

(patch -l -p 2 -i file.patch)

Fix conversion bug.  ("<=" was converted to "<" with calDate.compare.)

Thanks for the conversion!

Comment 12

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 195085 [details] [diff] [review]
Fix conversion bug: '<' --> '<='

r=mvl

Comment 13

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in. The testcase not also works. thanks for the fix!