251796 - unable to shift-click to select items in Bookmarks sidebar

Status: VERIFIED INVALID

(Firefox :: Bookmarks & History, defect)

Description

[sairuh (rarely reading bugmail)]

found using 2004-07-15-09-0.9 (branch) on Mac OS X 10.3.4. I can shift-click to
select a range of items in the History Sidebar, but I cannot do the same in the
Bookmarks Sidebar. not sure if this is expected behavior, but couldn't find an
existing bug on it.

found while running http://testrunner.mozilla.org/test.cgi#725

1. make sure you have more than three bookmarks listed in the Bookmarks Sidebar.

2. click one (it'll load in the page).

3. shift-click another.

expected: the range between the items clicked in steps 2 and 3 are selected.

actual results: the second point at which you shift-click (at step 3) just loads
that second item in the web content.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

It's expected, but I'm not sure it's correct -- shift-clicking loads the item in
a new window for me, which I think is consistent with shift-clicking on
bookmarks everywhere other than the bookmarks manager (bookmarks toolbar,
bookmarks menu).  I agree that it's a little odd though -- the bookmarks sidebar
can't seem to decide whether it's a mini bookmarks manager or a tree
representation of the bookmarks menu; it seems to be leaning towards the latter.

Comment 2

[Mike Connor [:mconnor]]

mixing shift-click and single-click default actions is pretty ugly.  Shift-click
to select multiple only makes sense if the action of a single click is to select.

If the bookmarks sidebar is a tree representation of bookmarks, then this
is/should be WONTFIX.  If its a bookmarks manager replacement, then we need to
switch to double-click and drop the click modifiers.  Given that the bookmarks
sidebar is relatively inadequate to manage large numbers of bookmarks, I think
the former is probably the right answer.

Comment 3

[Mike Connor [:mconnor]]

Talked about this previously with ben.  We're moving towards the bookmarks
sidebar being a quick-access medium, not a management setup, so we're going to
go with the single-click setup we currently have.  Trying to mix concepts is
just a Bad Thing(tm)

Comment 4

[Asa Dotzler [:asa]]

Sairuh, Tracy, we're going to need to amend our testcase for this one.

Comment 5

[sairuh (rarely reading bugmail)]

> Sairuh, Tracy, we're going to need to amend our testcase for this one.

done, updated testcase and vrfy'ing this as invalid.

Comment 6

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change