251898 - Add function information to PatchReader output.

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Christian Reis]

It's trivial to add function information to PatchReader output (with the
upcoming 0.9.5). Patch coming up.

Comment 1

[Christian Reis]

Attachment: kiko_v1: here comes the extra data!

This also aligns the (link here) text to the right.

Comment 2

[John Keiser (jkeiser)]

Comment on attachment 153523 [details] [diff] [review]
kiko_v1: here comes the extra data!

Given that most patches don't have func_info, could you not show the @@ if
there's no func_info?  Other than that, looks fine.

Comment 3

[Christian Reis]

Attachment: kiko_v2: good idea

Done.

Comment 4

[John Keiser (jkeiser)]

Comment on attachment 153532 [details] [diff] [review]
kiko_v2: good idea

Neat.

Comment 5

[Christian Reis]

This is a template-only change, and it might be nice to include in 2.18 --
minor, changes to a rather internal template. If we do this, we should bump up
the PatchReader requirement. Otherwise, let the cutting-edge people enjoy this
"exclusive feature -- but hurry, offer only valid while 2.18 lasts!".

Let me know if I should bump up the PR requirement on the trunk -- it's really
not required, just that people with 0.9.5 get nicer output than others.

Comment 6

[John Keiser (jkeiser)]

Note that it is backwards compatible, too.  This template will work with older
versions of PatchReader since they will just never send func_info.

Comment 7

[Christian Reis]

Done. Thanks!

/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/diff-file.html.tmpl,v
 <--  diff-file.html.tmpl
new revision: 1.3; previous revision: 1.2

Comment 8

[Frédéric Buclin]

This looks pretty minor and this information only appears if the patch creator decided to include it. I don't think this needs to be documented.