251905 - 'sanitize' |nsMsgCompField| (an implementation of nsIMsgCompField)

Status: NEW

(MailNews Core :: Composition, defect)

Description

[Jungshik Shin]

a spin-off of bug 250405. 

nsMsgCompField implements nsIMsgCompField. While doing it, it "overloads"
|m_body| in nsCString  as |AString body| in the interface  and as the C string
representation of what's to be sent out on the wire. In the former case, it's in
UTF-8 whearas in the latter, it's in the MIME charset of outgoing messages. It
also has two versions of |SetBody| and |GetBody|. One of them is the acecssor to
|AString body| while the other is for accessing the actual message body to be
sent out on the wire.  

Because of this overloading, one has to keep track of which of these two is
stored in |m_body|, which makes it hard to read the code.

Comment 1

[Wayne Mery (:wsmwk)]

Simon, reassign if you don't want

Comment 2

[buovjaga]

https://hg.mozilla.org/comm-central/file/tip/mailnews/compose/src/nsMsgCompFields.h

It doesn't have two versions of SetBody and GetBody anymore.