251939 - 23 errors in npunix.c

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[g. fischer]

User-Agent:       
Build Identifier: 

irix 6.5.24, mipspro 7.41
-------------------------

cc -o npunix.o -c -DOSTYPE=\"IRIX6\" -DOSARCH=\"IRIX\" 
-I../../../../dist/include/java -I../../../../dist/include/plugin
-I../../../../dist/include/plugin -I../../../../dist/include
-I/mnt/3/moz/obj2/dist/include/nspr        -KPIC -I/usr/local/include
-I/usr/nekoware/include  -woff 3262 -G 4 -n32  -DNDEBUG -DTRIMMED -O3 
-I/usr/local/include -I/usr/nekoware/include  -DMOZILLA_VERSION=\"1.8a3\"
-DIRIX=1 -DNSCAP_DISABLE_DEBUG_PTR_TYPES=1 -DD_INO=d_ino -DSTDC_HEADERS=1
-DHAVE_ST_BLKSIZE=1 -DHAVE_SIGINFO_T=1 -DHAVE_INT16_T=1 -DHAVE_INT32_T=1
-DHAVE_INT64_T=1 -DHAVE_UINT=1 -DHAVE_UINT_T=1 -DHAVE_UINT16_T=1
-DHAVE_DIRENT_H=1 -DHAVE_GETOPT_H=1 -DHAVE_MEMORY_H=1 -DHAVE_UNISTD_H=1
-DHAVE_NL_TYPES_H=1 -DHAVE_MALLOC_H=1 -DHAVE_X11_XKBLIB_H=1
-DHAVE_SYS_STATVFS_H=1 -DHAVE_SYS_STATFS_H=1 -DHAVE_SYS_CDEFS_H=1 -DHAVE_LIBM=1
-DHAVE_LIBDL=1 -DHAVE_LIBSOCKET=1 -DFUNCPROTO=15 -DHAVE_XSHM=1 -DHAVE_RANDOM=1
-DHAVE_STRERROR=1 -DHAVE_LCHOWN=1 -DHAVE_FCHMOD=1 -DHAVE_SNPRINTF=1
-DHAVE_MEMMOVE=1 -DHAVE_RINT=1 -DHAVE_STAT64=1 -DHAVE_LSTAT64=1
-DHAVE_FLOCKFILE=1 -DHAVE_LOCALTIME_R=1 -DHAVE_STRTOK_R=1
-DHAVE_LANGINFO_CODESET=1 -DHAVE_I18N_LC_MESSAGES=1
-DMOZ_DEFAULT_TOOLKIT=\"gtk2\" -DMOZ_WIDGET_GTK2=1 -DMOZ_ENABLE_XREMOTE=1
-DMOZ_X11=1 -DMOZ_PHOENIX=1 -DMOZ_XUL_APP=1 -DMOZ_APP_NAME=\"firefox\"
-DMOZ_ENABLE_XFT=1 -DMOZ_ENABLE_COREXFONTS=1 -DMOZ_EXTRA_X11CONVERTERS=1 -DOJI=1
-DIBMBIDI=1 -DMOZ_VIEW_SOURCE=1 -DACCESSIBILITY=1 -DMOZ_XPINSTALL=1
-DMOZ_JSLOADER=1 -DHAVE_GSSAPI_GSSAPI_H=1 -DMOZ_MATHML=1 -DMOZ_LOGGING=1
-DMOZ_USER_DIR=\".mozilla\" -DMOZ_XUL=1 -DMOZ_PROFILELOCKING=1
-DMOZ_DLL_SUFFIX=\".so\" -DXP_UNIX=1 -DUNIX_ASYNC_DNS=1 -DJS_THREADSAFE=1
-DNS_PRINT_PREVIEW=1 -DNS_PRINTING=1 -DMOZ_ACCESSIBILITY_ATK=1
-DMOZILLA_LOCALE_VERSION=\"1.8a\" -DMOZILLA_REGION_VERSION=\"1.8a\"
-DMOZILLA_SKIN_VERSION=\"1.5\"  -D_MOZILLA_CONFIG_H_ -DMOZILLA_CLIENT
../../../../../mozilla/modules/plugin/samples/unixprinting/npunix.c

cc-1020 cc: ERROR File = ../../../../dist/include/plugin/npruntime.h, Line = 135
  The identifier "bool" is undefined.

          bool boolValue;
          ^

cc-1020 cc: ERROR File = ../../../../dist/include/plugin/npruntime.h, Line = 257
  The identifier "bool" is undefined.

  bool NPN_IdentifierIsString(NPIdentifier *identifier);
  ^

cc-1079 cc: ERROR File = ../../../../dist/include/plugin/npruntime.h, Line = 280
  A type specifier is expected.

  typedef bool (*NPHasMethodFunctionPtr)(NPObject *npobj, NPIdentifier name);
                ^

cc-1090 cc: ERROR File = ../../../../dist/include/plugin/npruntime.h, Line = 280
  Function returning function is not allowed.

  typedef bool (*NPHasMethodFunctionPtr)(NPObject *npobj, NPIdentifier name);
                                         ^

cc-1233 cc: WARNING File = ../../../../dist/include/plugin/npruntime.h, Line =
280
  An explicit type is missing ("int" assumed).

  typedef bool (*NPHasMethodFunctionPtr)(NPObject *npobj, NPIdentifier name);
          ^

cc-1090 cc: ERROR File = ../../../../dist/include/plugin/npruntime.h, Line = 281
  Function returning function is not allowed.

  typedef bool (*NPInvokeFunctionPtr)(NPObject *npobj, NPIdentifier name,
                 ^

cc-1090 cc: ERROR File = ../../../../dist/include/plugin/npruntime.h, Line = 284
  Function returning function is not allowed.

  typedef bool (*NPHasPropertyFunctionPtr)(NPObject *npobj, NPIdentifier name);
                 ^

cc-1090 cc: ERROR File = ../../../../dist/include/plugin/npruntime.h, Line = 285
  Function returning function is not allowed.

  typedef bool (*NPGetPropertyFunctionPtr)(NPObject *npobj, NPIdentifier name,
                 ^

cc-1090 cc: ERROR File = ../../../../dist/include/plugin/npruntime.h, Line = 287
  Function returning function is not allowed.

  typedef bool (*NPSetPropertyFunctionPtr)(NPObject *npobj, NPIdentifier name,
                 ^

cc-1090 cc: ERROR File = ../../../../dist/include/plugin/npruntime.h, Line = 289
  Function returning function is not allowed.

  typedef bool (*NPRemovePropertyFunctionPtr)(NPObject *npobj, NPIdentifier
name);
                 ^

cc-1020 cc: ERROR File = ../../../../dist/include/plugin/npruntime.h, Line = 315
  The identifier "NPHasMethodFunctionPtr" is undefined.

      NPHasMethodFunctionPtr hasMethod;
      ^

cc-1090 cc: ERROR File = ../../../../dist/include/plugin/npruntime.h, Line = 365
  Function returning function is not allowed.

  bool NPN_Call(NPObject *npobj, NPIdentifier methodName,
       ^

cc-1090 cc: ERROR File = ../../../../dist/include/plugin/npruntime.h, Line = 367
  Function returning function is not allowed.

  bool NPN_Evaluate(NPP npp, NPObject *npobj, NPString *script,
       ^

cc-1090 cc: ERROR File = ../../../../dist/include/plugin/npruntime.h, Line = 369
  Function returning function is not allowed.

  bool NPN_GetProperty(NPObject *npobj, NPIdentifier propertyName,
       ^

cc-1090 cc: ERROR File = ../../../../dist/include/plugin/npruntime.h, Line = 371
  Function returning function is not allowed.

  bool NPN_SetProperty(NPObject *npobj, NPIdentifier propertyName,
       ^

cc-1090 cc: ERROR File = ../../../../dist/include/plugin/npruntime.h, Line = 373
  Function returning function is not allowed.

  bool NPN_RemoveProperty(NPObject *npobj, NPIdentifier propertyName);
       ^

cc-1090 cc: ERROR File = ../../../../dist/include/plugin/npruntime.h, Line = 374
  Function returning function is not allowed.

  bool NPN_HasProperty(NPObject *npobj, NPIdentifier propertyName);
       ^

cc-1090 cc: ERROR File = ../../../../dist/include/plugin/npruntime.h, Line = 375
  Function returning function is not allowed.

  bool NPN_HasMethod(NPObject *npobj, NPIdentifier methodName);
       ^

cc-1090 cc: ERROR File = ../../../../dist/include/plugin/npupp.h, Line = 1164
  Function returning function is not allowed.

  typedef bool (* NP_LOADDS NPN_IdentifierIsStringUPP)(NPIdentifier identifier);
                            ^

cc-1090 cc: ERROR File = ../../../../dist/include/plugin/npupp.h, Line = 1324
  Function returning function is not allowed.

  typedef bool (* NP_LOADDS NPN_CallUPP)(NPObject* obj, NPIdentifier methodName,
const NPVariant *args, uint32_t argCount, NPVariant *result);
                            ^

cc-1090 cc: ERROR File = ../../../../dist/include/plugin/npupp.h, Line = 1353
  Function returning function is not allowed.

  typedef bool (* NP_LOADDS NPN_EvaluateUPP)(NPP npp, NPObject *obj, NPString
*script, NPVariant *result);
                            ^

cc-1090 cc: ERROR File = ../../../../dist/include/plugin/npupp.h, Line = 1381
  Function returning function is not allowed.

  typedef bool (* NP_LOADDS NPN_GetPropertyUPP)(NPObject *obj, NPIdentifier
propertyName, NPVariant *result);
                            ^

cc-1090 cc: ERROR File = ../../../../dist/include/plugin/npupp.h, Line = 1409
  Function returning function is not allowed.

  typedef bool (* NP_LOADDS NPN_SetPropertyUPP)(NPObject *obj, NPIdentifier
propertyName, const NPVariant *value);
                            ^

cc-1090 cc: ERROR File = ../../../../dist/include/plugin/npupp.h, Line = 1436
  Function returning function is not allowed.

  typedef bool (* NP_LOADDS NPN_RemovePropertyUPP)(NPObject *obj, NPIdentifier
propertyName);
                            ^

23 errors detected in the compilation of
"../../../../../mozilla/modules/plugin/samples/unixprinting/npunix.c".
gmake[3]: *** [npunix.o] Error 2
gmake[3]: *** Waiting for unfinished jobs....


Reproducible: Always
Steps to Reproduce:
1.compile it
2.
3.

Actual Results:  
build fails

Expected Results:  
build

Comment 1

[Robert Guenther]

These Error come from missing type definitions in 
dist/include/plugin/nptypes.h.

Line 51 should be
#elif defined(_AIX) || defined(__sun) || defined(__osf__) || defined(IRIX)
                                                         ^^^^^^^^^^^^^^^^^
                                                                new!
PS Can someone please incorpate it into a patch file?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: Suggested change

Patch suggested by Robert Guenther.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 157495 [details] [diff] [review]
Suggested change

Don't know who to ask for review, please correct if I'm wrong.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

not firefox specific. -> browser.

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 157495 [details] [diff] [review]
Suggested change

sr+a=jst

Comment 6

[Johnny Stenback (:jst)]

Thanks for the patch! Fixed on trunk and aviary branc.

Comment 7

[g. fischer]

thanks!!

but this one is much more important!
http://bugzilla.mozilla.org/show_bug.cgi?id=252207

thanks again

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 257667 has been marked as a duplicate of this bug. ***