252005 - Cannot change capitalisation of Groups

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[GavinS]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-gb) AppleWebKit/125.2 (KHTML, like Gecko) Safari/125.8
Build Identifier: 

Spun off from bug#86501

Reproducible: Always
Steps to Reproduce:

Comment 1

[GavinS]

Actually spun off from bug#86051

Comment 2

[Steve]

Attachment: Fix to allow capitalization of Groups (in edit)

Comment 3

[Max Kanat-Alexander]

Comment on attachment 450981 [details] [diff] [review]
Fix to allow capitalization of Groups (in edit)

No, because this would allow modifying one group to have a name that is case-insensitively the same as another.

Instead, see how Bugzilla::Version::_check_value works.

Comment 4

[Steve]

No it wouldn't. I guess you didn;t check the modification yourself.

If you attempt to greate TWO groups. One called 'Test' and another called 'test', you will get an error on the second of 'The group test already exists.' 


If you create one group called 'Test'. Then create a group called 'Test1'.
Edit the group called 'Test1" to 'test' and you stioll get the same error 'The group test already exists.'

This bug fix will NOT allow you to modify a group to have a case insensitive name as another.

Comment 5

[Steve]

I did just notice one error though. The version diff is the wrong way around. + is - and - is +, doh.

Comment 6

[Steve]

Attachment: Fixed Diff (correct way round now)

Comment 7

[Max Kanat-Alexander]

Comment on attachment 451124 [details] [diff] [review]
Fixed Diff (correct way round now)

Oh, I see what you mean. I think it would still be better to check the id, but this is fine.

Comment 8

[Max Kanat-Alexander]

Thanks for the patch, Steve! :-)

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Group.pm
Committed revision 7220.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/
modified Bugzilla/Group.pm
Committed revision 7106.