252182 - Extensions are not correctly re-enabled after -safe-mode

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dorando]

User-Agent:       Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.7) Gecko/20040626 Firefox/0.9.1
Build Identifier: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.7) Gecko/20040719 Firefox/0.9.1+

After having started with -safe-mode, Firefox doesn't load default preferences
files anymore.

Reproducible: Always
Steps to Reproduce:
1. Install an extension which provides default preferences files (Magpie 3.11)
2. Restart
3. Restart with -safe-mode
4. Restart without -safe-mode
5. Search about:config for the defaults prefs (bengoodger.com.tabdownloader.*)
Actual Results:  
Default preferences files are not loaded

Expected Results:  
Default preferences files are loaded

To recover from this bug disable any extension and re-enable it.

Original bug report by Martin Heller (
http://forums.mozillazine.org/viewtopic.php?p=656111#656111 )

Comment 1

[Michael O.]

Confirming that this happens on Win98 and WinXP as well. It breaks all of my
extensions now that I use a default preference file as outlined in the
"Extension File Layout" section of Ben's "Packaging Firefox/Thunderbird
Extensions" document.

http://www.bengoodger.com/software/mb/extensions/packaging/extensions.html

This error affects files in the components/ directory as well, which can be seen
in the Firesomething extension with the about:firefox and about:firesomething
fetaures.

Comment 2

[chris hofmann]

shooting for 1.0

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

make sure we write bin/profile defaults.ini files in the right place, not both
in the profile (clobbering profile extension data with global extension
data)...

also fix some js errors preventing theme reversion from happening in safe mode

... and get rid of "optional components" section in update wizard