252193 - make seamonkey bookmarks use nsISafeOutputStream

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[[e-mail]]

this is the twin of bug 252053 (firefox). copy-paste:

convert another consumer over to using our new safe-save functionality (see bug
246675).

doing so will fix the following open bugs (there are both seamonkey and fx bugs
in this list, but it's all really the same thing):

157152 (by not leaving the tempfile around in the failure case)
220159 (maybe... not sure what's going on here)
206567 (once i land a fix to the safe-save impl, see bug 252050)

Comment 1

[[e-mail]]

Attachment: v1

Comment 2

[[e-mail]]

timeless: may i ask... any particular reason we use PR_WRONLY for the ioflags on
the output stream, and not the -1 default?

Comment 3

[timeless]

you may ask, but don't ask me, that dates to:
1.280 <[e-mail]> 2003-04-02 05:11
Fix for bug 191783 Convert bookmark implemenation to use nsIFile instead of
nsFileSpec

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 153717 [details] [diff] [review]
v1

+						   PR_WRONLY,

please use the default here (-1).

wait with the checkin until you checked in bug 252050

Comment 5

[[e-mail]]

Comment on attachment 153717 [details] [diff] [review]
v1

another simple consumer fix for you darin ;)

Comment 6

[[e-mail]]

fixed-on-trunk.