CERT_VerifyCert with param certUsageVerifyCA fails or asserts

RESOLVED FIXED in 3.9.3

Status

NSS
Libraries
P1
normal
RESOLVED FIXED
13 years ago
11 years ago

People

(Reporter: kaie, Assigned: Nelson Bolyard (seldom reads bugmail))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

13 years ago
Bob recommended I could call CERT_VerifyCert with certUsageVerifyCA to check
whether the given cert is a valid CA cert.
However, this crashes using NSS code on branch MOZILLA_1_7_0_BRANCH as of
Mozilla 1.7.1
(Reporter)

Comment 1

13 years ago
Created attachment 153769 [details] [diff] [review]
Proposed fix

If you agree with this patch, I would like to land it on MOZILLA_1_7_0_BRANCH
as part of the fix for bug 249004.

Comment 2

13 years ago
Comment on attachment 153769 [details] [diff] [review]
Proposed fix

I'd like Julien to review this as well. If it goes in, I'd like to see it go
into the trunk and 3.9 branch as well.

bob
Attachment #153769 - Flags: superreview?(julien.pierre.bugs)
Attachment #153769 - Flags: review+

Comment 3

13 years ago
Kai,

Was this case just asserting in the "default" case of the switch statement, or
is it also crashing in optimized code, and if so, how ? I'd like to understand
this better before putting the sr+ flag.
(Reporter)

Comment 4

13 years ago
Julien, yes, it was crashing because of the PORT_Assert in the default statement.

Updated

13 years ago
Attachment #153769 - Flags: superreview?(julien.pierre.bugs) → superreview+

Updated

13 years ago
Summary: CERT_VerifyCert with param certUsageVerifyCA crashes → CERT_VerifyCert with param certUsageVerifyCA fails or asserts
(Reporter)

Comment 5

13 years ago
Could you please include this patch in NSS_CLIENT_TAG?
This is required to land bug 249004 on the trunk of Mozilla.
Thanks a lot.
(Reporter)

Updated

13 years ago
Depends on: 249004
(Reporter)

Updated

13 years ago
Blocks: 249004
No longer depends on: 249004
(Assignee)

Comment 6

13 years ago
Marking P1 for NSS 3.9.3.  

Note that this bug (midssing case) was fixed on the trunk in rev 1.65, 
back in April.  That revision was supposently ported to the NSS 3.9 branch
for mozilla 1.7, but this fix was apprently omitted.  :( 
So, this patch needs to go into the 3.9 branch, and the tag moved to the 
new revision for that file only.  
Priority: -- → P1
Target Milestone: --- → 3.9.3
(Assignee)

Comment 7

13 years ago
Taking bug.
Assignee: wchang0222 → nelson
Hardware: PC → All
Version: unspecified → 3.9
(Assignee)

Comment 8

13 years ago
Checking in certdb.c; new revision: 1.61.2.4; previous revision: 1.61.2.3

I moved the NSS_CLIENT_TAG from 1.61.2.3 to 1.61.2.4
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.