Bob recommended I could call CERT_VerifyCert with certUsageVerifyCA to check whether the given cert is a valid CA cert. However, this crashes using NSS code on branch MOZILLA_1_7_0_BRANCH as of Mozilla 1.7.1
Created attachment 153769 [details] [diff] [review] Proposed fix If you agree with this patch, I would like to land it on MOZILLA_1_7_0_BRANCH as part of the fix for bug 249004.
Comment on attachment 153769 [details] [diff] [review] Proposed fix I'd like Julien to review this as well. If it goes in, I'd like to see it go into the trunk and 3.9 branch as well. bob
Kai, Was this case just asserting in the "default" case of the switch statement, or is it also crashing in optimized code, and if so, how ? I'd like to understand this better before putting the sr+ flag.
Julien, yes, it was crashing because of the PORT_Assert in the default statement.
Could you please include this patch in NSS_CLIENT_TAG? This is required to land bug 249004 on the trunk of Mozilla. Thanks a lot.
Marking P1 for NSS 3.9.3. Note that this bug (midssing case) was fixed on the trunk in rev 1.65, back in April. That revision was supposently ported to the NSS 3.9 branch for mozilla 1.7, but this fix was apprently omitted. :( So, this patch needs to go into the 3.9 branch, and the tag moved to the new revision for that file only.
Checking in certdb.c; new revision: 18.104.22.168; previous revision: 22.214.171.124 I moved the NSS_CLIENT_TAG from 126.96.36.199 to 188.8.131.52