Closed Bug 252362 Opened 21 years ago Closed 19 years ago

security warning preferences should be exposed in user interface

Categories

(Firefox :: Settings UI, defect, P3)

2.0 Branch
defect

Tracking

()

RESOLVED FIXED
Firefox 2 beta1

People

(Reporter: dbaron, Assigned: Gavin)

References

Details

(Keywords: fixed1.8.1)

Attachments

(2 files, 2 obsolete files)

There should be UI to expose the security warning dialog preferences, on the general principle that what the user does through the user interface (since the dialogs show once by default) he should be able to undo through the user interface. Breaking that principle can lead to significant user frustration. The actual prefs I'm talking about are security.warn_*, and one checkbox should be needed for each pair of these preferences. Changing the checkbox should set the corresponding pref to the checkbox and the corresponding pref_show_once to false.
This problem seems to have been pursued under bug 257233.
*** Bug 257233 has been marked as a duplicate of this bug. ***
*** Bug 258691 has been marked as a duplicate of this bug. ***
OS: Linux → All
Hardware: PC → All
Flags: blocking1.8.1?
Flags: blocking-aviary2?
Is it possible to implement this for Fx 2.0?
Assignee: firefox → nobody
QA Contact: mconnor → preferences
Really should figure this one out finally.
Flags: blocking-firefox2? → blocking-firefox2+
Keywords: helpwanted
Target Milestone: --- → Firefox 2
Attached patch first pass (obsolete) — Splinter Review
This works, but really needs some UI/wording help. I used the same labels as in the dialogs, which I think need improvement (while it may work in the dialogs, I don't think the first-person pronoun fits in very well in the preferences dialog). They don't necessarily have to be the same, either. I also added a "Security Warnings" pane, but that seems somewhat redundant next to the "Security" tab, which didn't have enough room to fit all the checkboxes without increasing the height of the prefwindow. I couldn't think of a better name or place, so again, "UI helpwanted".
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Whiteboard: [needs ui review]
Keywords: helpwanteduiwanted
Whiteboard: [needs ui review]
(In reply to comment #6) > I couldn't think of a better name or place, so again, "UI helpwanted". Maybe instead of a tab it would be better to put these options in another window (just like Connection Settings in Prefs > General or the Advanced JS Settings in Prefs > Content), and in the "Security" tab just a button which would open that window?
Ugh, the security preferences are a bit of a nightmare. Comment 7 makes a good point, which is that a "Security Warnings" tab next to "Security" is a little odd. However, I can't help but wonder if these are all security warnings, or if there are other "don't ask me again" checkboxes that aren't security warnings we could include here. If so, then a full tab might make sense, but instead call it "Warning Dialogs" or just "Warnings" Wherever we put this, we can probably factor out the "Warn me when ..." text: Show a warning dialog when: [ ] I am about to view an encrypted page [ ] I am about to view a page that uses low-grade encryption [ ] The polar ice caps melt, drowning the eastern seaboard etc
Attached patch approach #2 (obsolete) — Splinter Review
Thanks for the feedback! This takes into account comment 7 and comment 8, by adding a button instead of a tab and refactoring the text to make it simpler. I'm not sure I like the fact that it requires increasing the height of the prefwindow, and the dialog still looks kind of bare, I think, but it's food for thought. I'll attach a screenshot in a bit.
Attachment #208501 - Attachment is obsolete: true
Also, there was mention in bug 257233 of a "reset warnings to default" button - I don't think it's really necessary, given clear options for which dialogs to show. I don't think there's anything special about the default options that would merit adding a button to revert to them.
Target Milestone: Firefox 2 → Firefox 2 beta1
Looks good, Gavin. I agree that resetting the warnings isn't a useful feature to add in.
Priority: -- → P3
Whiteboard: [swag: 0.5d]
(removing uiwanted)
Keywords: uiwanted
Attachment #210785 - Attachment is obsolete: true
Attachment #223570 - Flags: ui-review?(beltzner)
Attachment #223570 - Flags: review?(mconnor)
Whiteboard: [swag: 0.5d] → [patch-r?]
Comment on attachment 223570 [details] [diff] [review] approach #2 unbitrotted So, I'm not sure what the right fix is here. technically, the patch is ok, but I think I'd rather add another tab ("Warnings" or something) instead of a groupbox and a dialog.
But a tab within a tab? Ugh. What's the objection? A single item in the groupbox, or the fact that it's split into its own dialog.
Comment on attachment 223570 [details] [diff] [review] approach #2 unbitrotted ui-r=me
Attachment #223570 - Flags: ui-review?(beltzner) → ui-review+
Comment on attachment 223570 [details] [diff] [review] approach #2 unbitrotted The profusion of child dialogs is worse than the tab within a tab case, IMO. Tab-in-tab doesn't seem to be breaking anyone right now with the two panes where its already being used. As much as it sucks, child prefwindows suck more. r=me, because we need to do something, and it looks like the prefwindow reorg is slipping
Attachment #223570 - Flags: review?(mconnor) → review+
Attachment #223570 - Flags: approval-branch-1.8.1+
Whiteboard: [patch-r?] → [checkin needed]
Checked in, branch and trunk.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Version: unspecified → 2.0 Branch
Blocks: 339780
will this patch have the ability to stop the "Domain miss-match" security window coming up?
(In reply to comment #9) There is no explanation in the firefox help file about what these options mean. If users don't know, they'll first look there. I don't think these settings are self-explanatory. This is what it now says: << Warnings Configure Security Warnings Click this button to configure the security warnings Bon Echo displays while you browse the web. >> Which doesn't say much at all. There could be a explanation of each setting, noting their defaults and each default was chosen. (If an average user changes a setting here, I think it will be difficult for him to later remember what the default was.)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: