Closed
Bug 252536
Opened 21 years ago
Closed 21 years ago
turn off unnecessary printfs in mac plugin code (make debug only)
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jaas, Assigned: mikepinkerton)
Details
Attachments
(1 file)
|
1.28 KB,
patch
|
mikepinkerton
:
review+
sfraser_bugs
:
superreview+
|
Details | Diff | Splinter Review |
After installing a new java plugin for Camino, I started getting lots of
messages in my console from the plugin code. They aren't necessary and should
only be built in with debug builds - perhaps not even there?
Patch is attached, though it migth be better to simply remove the printf lines
than apply my patch to make the debug only.
Attachment #153944 -
Flags: superreview?(bryner)
Attachment #153944 -
Flags: superreview?(bryner) → superreview?(sfraser)
This is really annoying (for me as a developer that pays lots of attention to
logs) and the patch is trivial. Should be included in the Camino 0.8 branch as
well as the trunk.
Assignee: bryner → pinkerton
Attachment #153944 -
Flags: superreview?(sfraser)
Attachment #153944 -
Flags: superreview?(pinkerton)
Attachment #153944 -
Flags: review?(bryner)
|
Assignee | |
Comment 3•21 years ago
|
||
Comment on attachment 153944 [details] [diff] [review]
make printfs debug only
r=pink, i can't sr this, but it's a pretting much a rubber stamp.
asking smfr who actually responds to sr requsets ;)
Attachment #153944 -
Flags: superreview?(sfraser)
Attachment #153944 -
Flags: superreview?(pinkerton)
Attachment #153944 -
Flags: review?(bryner)
Attachment #153944 -
Flags: review+
|
||
Updated•21 years ago
|
Attachment #153944 -
Flags: superreview?(sfraser) → superreview+
|
|
Assignee | |
Comment 4•21 years ago
|
||
done.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•