252599 - 'Add a Keyword for this Search' doesn't save all form elements (checkbox, radio button)

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Ivan Sagalaev]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040718 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040718 Firefox/0.9.1+

Many sites use a common NN4-era hack for laying out forms:

<table>
  <form action=...>
    <tr><td><input...></td></tr>
    <tr><td><input...></td></tr>
  </form>
</table>

Adding a keyword for such search doesn't include all the useful elements (e.g.
modifying checkboxes) in the bookmark created.

Reproducible: Always
Steps to Reproduce:
1. Go to http://gramota.ru/
2. Notice a form on the right side with many checked checkboxes
3. Add a keyword for this search from popup menu
4. Use a keyword

Actual Results:  
On the result page no checkboxes checked (the form is now on the left)
Keyword doesn't contain checkboxes names in URL

Expected Results:  
All checkboxes should be checked

Comment 1

[Nickolay_Ponomarev]

Seeing this with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3)
Gecko/20040903 Firefox/1.0 PR (NOT FINAL) and
http://forums.mozillazine.org/search.php [search on a phpBB forum]. Perhaps it
will be easier to confirm the bug now for english-speaking people.

Other people are also seeing this -
http://forums.mozillazine.org/viewtopic.php?p=767091#767091

Comment 2

[Asaf Romano (gone)]

It seems as chekboxes and radio elements are never handled by "add keyword", the
<tr> element is not related.

Comment 3

[Asaf Romano (gone)]

Attachment: testcase

Comment 4

[Asaf Romano (gone)]

Attachment: testcase

oops, i forgot the textbox.

Comment 5

[rOmAz]

Attachment: patch

adds support in "Add a Keyword for this Search" for radio buttons and
checkboxes for both POST and GET methods

-rOmAz

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 160011 [details] [diff] [review]
patch

r=[e-mail]

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 160011 [details] [diff] [review]
patch

a=asa for aviary checkin.

Comment 8

[Asa Dotzler [:asa]]

Is someone going to land this fix? 

Comment 9

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Whoops, forgot.  Landed on aviary.

Comment 10

[Ivan Sagalaev]

Just checked on initial URL. Working indeed.