252636 - Download manager renames files poorly (changes version numbers) when file already exists.

Status: VERIFIED DUPLICATE of bug 231048

(Toolkit :: Downloads API, defect)

Description

[Zac Jacobson]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.2; .NET CLR 1.1.4322; .NET CLR 2.0.40607)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.7) Gecko/20040707 Firefox/0.9.2

When downloading files with the Download manager, the program renames files if 
there is already an existing one with the same name.  The way it renames files 
seems to be flawed.  It changes digits in the middle of the file name.  This is 
especially bad when dealing with file names that have version numbers in them.  
For example:

When I download this file the first time it works:

Paradata-PHP-1.6.3.zip

But subsequent downloads rename this file to:

Paradata-PHP-2.6.3.zip
Paradata-PHP-3.6.3.zip
Paradata-PHP-4.6.3.zip

Etc.
  

It seems like it is looking for the first period in the name and then if there 
is a number before it, it increments it.  I think it should look for the last 
period and not change the original file name, only append to it.

Reproducible: Always
Steps to Reproduce:
1. Download a file that has a digit followed by a period followed by more 
characters and at least one more period.

Actual Results:  
Download manager renamed the file by incrementing the digit in front of the 
first period.

Expected Results:  
Appended a digit to the end of the original filename, but before the real file 
extension.  It should look for the LAST period, not the first one.

Comment 1

[Ali Ebrahim]

*** This bug has been marked as a duplicate of 229062 ***

Comment 2

[Ali Ebrahim]

*** This bug has been marked as a duplicate of 231048 ***