252681 - mozISpellCheckingEngine check method faulting on misspelled words

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Robert Strong (they/them - no direct email)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040719 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040719 Firefox/0.9.1+

When using the following javascript - the check method always works with a
correctly spelled word and always faults when passing a misspelled word.
var spellChecker = Components.classes['@mozilla.org/spellchecker/myspell;1']
.createInstance().QueryInterface(Components.interfaces.mozISpellCheckingEngine);
spellChecker.dictionary = "en-US";
alert("two is spelled correctly? " + spellChecker.check("two"));
alert("twoo is spelled correctly? " + spellChecker.check("twoo"));

I have also noticed that the suggest method also faults which is probably related.

Reproducible: Always
Steps to Reproduce:
1. Add this code to an extension
var spellChecker = Components.classes['@mozilla.org/spellchecker/myspell;1']
.createInstance().QueryInterface(Components.interfaces.mozISpellCheckingEngine);
spellChecker.dictionary = "en-US";
alert("two is spelled correctly? " + spellChecker.check("two"));
alert("twoo is spelled correctly? " + spellChecker.check("twoo"));
2. run the code

Actual Results:  
check returns true with a correctly spelled word
check faults and closes the application with an incorrectly spelled word

Expected Results:  
Return the appropriate value in both cases without faulting.

Faulting application firefox.exe, version 0.9.0.0, faulting module myspell.dll,
version 1.7.20040.62616, fault address 0x00002db9.

Comment 1

[Robert Strong (they/them - no direct email)]

Added the following two lines and it resolved my issue.

var persDict = Components.classes['@mozilla.org/spellchecker/personaldictionary;1']
.createInstance().QueryInterface(Components.interfaces.mozIPersonalDictionary);
spellChecker.personalDictionary = persDict;

Comment 2

[timeless]

it's a bug. we shouldn't crash.

Comment 3

[timeless]

Attachment: fix

js> var spellChecker =
Components.classes['@mozilla.org/spellchecker/myspell;1'].createInstance(Components.interfaces.mozISpellCheckingEngine);

js> spellChecker.dictionary = "en-US";
en-US
js> alert=print

function print() {
    [native code]
}

js> alert("two is spelled correctly? " + spellChecker.check("two"));
two is spelled correctly? true
js> alert("twoo is spelled correctly? " + spellChecker.check("twoo"));
twoo is spelled correctly? false
js> quit()

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 154068 [details] [diff] [review]
fix

yeah, a personal dictionary should be optional.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 154068 [details] [diff] [review]
fix

sr=dmose

Comment 6

[timeless]

mozilla/extensions/spellcheck/myspell/src/myspAffixmgr.cpp 	1.11