252756 - Sidebar appears when doing "search web for" even though it's turned off

Status: RESOLVED INVALID

(SeaMonkey :: Sidebar, defect)

Description

[Riley Abbe]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040714
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040714

under View, Show/Hide, Sidebar is unchecked.  However if I highlight any text
and right click it and choose "search web for (whatever)" in the sidebar will
activate and have to be closed again.  

Reproducible: Always
Steps to Reproduce:
1.  Disable the Sidebar
2.  Highlight text
3.  Use the search web for right click function

Actual Results:  
The browser will infact do the search using google, however the sidebar is now open.

Expected Results:  
Performed the web search while following the settings I have made to the browser
and not opened the sidebar.

Comment 1

[R.K.Aa.]

Edit->Preferences->Internet Search:
Uncheck "Open the Search tab in the Sidebar when search results are available"

Comment 2

[Riley Abbe]

(In reply to comment #1)
> Edit->Preferences->Internet Search:
> Uncheck "Open the Search tab in the Sidebar when search results are available"

Lol sorry for wasting your time on that.  Grr I hate it when stuff's right there
in front of me.

Comment 3

[R.K.Aa.]

verified per comment 2

Comment 4

[R.K.Aa.]

*** Bug 252802 has been marked as a duplicate of this bug. ***

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

er, reopening. if the sidebar is hidden (as opposed to collapsed or visible), we
should not open it. this was fixed before, but alas I can't find the bugs.

I blame bug 229753:
+    // make sure the sidebar is open, else SidebarSelectPanel() will fail
+    if (sidebar_is_hidden())
+      SidebarShowHide();

Comment 6

[[e-mail]]

But RevealSearchPanel is only called if autoOpenSearchPanel is set...