252839 - Remove &action=view from links in attachment table

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Christian Reis]

Remove &action=view from links in attachment table

Comment 1

[Christian Reis]

Attachment: kiko_v1: fix

Comment 2

[Christian Reis]

Comment on attachment 154163 [details] [diff] [review]
kiko_v1: fix

Reason for doing this is to avoid confusing shell-pasted links.

Comment 3

[GavinS]

Just noting that this is a subset of bug#232659

Comment 4

[[e-mail]]

Bah, when this goes in then suddenly all of my attachment history will go out of
date :-(

Note that on the Edit Attachment screen, the src of the <iframe> also has
&action=view

Comment 5

[Christian Reis]

Hmm, yeah, visited links will be reset. Minor inconvenience?

Comment 6

[timeless]

fairly major. but it's not like bugzilla has been very nice to bmo users 
lately, see the mybugs link, deleting broken searches and a few other things.

Comment 7

[Christian Reis]

I'm at a loss, because there's no way we can fix Neil's reported bug 232659
without breaking some link history (this is just a part of it). I like to think
I do as much as possible for bmo users because that's why I became involved in
Bugzilla in the first place; if you feel I've done less than my share please CC:
me to other bugs that need attention and I'll go out of my way to provide help.

Comment 8

[Dave Miller [:justdave]]

I'm assuming you're going to take care of the iframe src on the other bug?

Comment 9

[Christian Reis]

Yes, there's a patch there already.

Comment 10

[Christian Reis]

/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/list.html.tmpl,v
 <--  list.html.tmpl
new revision: 1.18; previous revision: 1.17

Thanks.