252859 - Support drag and drop of URLs from the browser to the RSS account

Status: VERIFIED FIXED

(MailNews Core :: Feed Reader, defect)

Description

[Scott MacGregor]

You should be able to drag a feed url from Firefox and drop it on either the RSS
root folder or an rss folder.

If you drop it on an rss folder, a subscription should be added for THAT folder.

If you drop it on an RSS account server, we should create a new folder for this
feed.

Comment 1

[Scott MacGregor]

Attachment: the fix

Comment 2

[Scott MacGregor]

Comment on attachment 154178 [details] [diff] [review]
the fix

David, this patch is doing several things:

1) I modified the shared messengerdnd.js file with some rss specific magic to
allow you to drop urls in the folder pane on top  of an rss server or an rss
folder and we'll subscribe ourselves to that url. I couldn't think of a way to
make this could work "dynamically" without including rss references in the drag
and drop JS file.

2) Adds a new method to nsINewsBlogFeedDownloader.idl which I see I forot to
include in the patch:

void subscribeToFeed(in string aUrl, in nsIMsgFolder aFolder, in nsIMsgWindow
aMsgWindow);

3) Make the progress notifcation object in newsblog.js handle some special
stuff if we are doing subscription via drag and drop.

4)Adds error reporting (Bug #252860). If you enter a url we can't parse, the
user gets an alert saying the specified URL was invalid. If the user gives a
bogus url we can't event connect to, they get a networking alert. Subscribe
dialog uses alerts to show this stuff. If you are using drag and drop in the
folder pane we just show status text in the urlbar.

5) Add some robustness to the feed downloader, making sure the url we are being
asked to fetch is an http url before we even try to open it, otherwise alert
the user about an invalid feed.

Comment 3

[David :Bienvenu]

Comment on attachment 154178 [details] [diff] [review]
the fix

you rock, Scott! My one comment is that this patch limits rss feeds to being
stored in sub-folders of rss servers/accounts (maybe we already have that
limitation). When if we allow deferring of rss accounts, we'll need to broaden
the drag drop to allow drop on any folder (or perhaps any local folder)

Comment 4

[Scott MacGregor]

fixed

Comment 5

[Tracy Walker [:tracy]]

Verified works on Windows 2004-08-30