Closed Bug 25288 Opened 25 years ago Closed 25 years ago

XPInstall Engine broken on Mac

Categories

(Core Graveyard :: Installer: XPInstall Engine, defect, P1)

Product:
Core Graveyard
Component:
Installer: XPInstall Engine
Platform:
PowerPC
Mac System 8.5
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: samir_bugzilla, Assigned: samir_bugzilla)

Details

The XPInstall engine does not work in this morning's installer or a build from 
yesterday. This has broken the installer.
Status: NEW → ASSIGNED
Priority: P3 → P1
Target Milestone: M14
Adding David and Paul to Cc.
Fix in hand: nsLocalFileMac issue. Sent for review to dougt.
Fix checked in with review from sdagley. 

JJ,
Can we respin the Mac installers with this fix? Thanks.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
I do not think that diff is correct.  It is an error if the mode is not 
PR_CREATE_FILE.  I think it should be something like:

if ((error != noErr) && (err != fnfErr && (flags & PR_CREATE_FILE)))
The diff you saw was old. When Steve reviewed this we changed it to effectively 
reflect the logic you have included below.
Build: 2000-02-15-09-M14(MAC)

Installations work.  Marking Verified!
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.