Closed
Bug 252943
Opened 21 years ago
Closed 21 years ago
broken title in interdiff
Categories
(Bugzilla :: Attachments & Requests, defect)
Bugzilla
Attachments & Requests
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: kiko, Assigned: kiko)
References
Details
Attachments
(1 file)
|
1.51 KB,
patch
|
bugreport
:
review+
|
Details | Diff | Splinter Review |
The interdiff action uses the same diff-header.html file, but that header
assumes it's always handling a single diff, which is false for interdiffs.
|
Assignee | |
Comment 1•21 years ago
|
||
Apart from fixing the header this adds a USE url that was missing (we had dead
links in the header, somehow) and removes some confusing double-linking.
|
|
Assignee | |
Updated•21 years ago
|
Attachment #154243 -
Flags: review?(bugreport)
|
||
Comment 2•21 years ago
|
||
Comment on attachment 154243 [details] [diff] [review]
kiko_v1: fixes
r=joel if you've tested it.
Attachment #154243 -
Flags: review?(bugreport) → review+
|
|
Assignee | |
Comment 3•21 years ago
|
||
Of course I have.
Requesting approval for trunk and 2.18 -- this is *clearly* broken on both trunk
and branch. Example:
http://bugzilla.mozilla.org/attachment.cgi?oldid=154238&action=interdiff&newid=154246&headers=1
Flags: approval?
Flags: approval2.18?
|
|
Assignee | |
Updated•21 years ago
|
Status: NEW → ASSIGNED
|
||
Updated•21 years ago
|
Flags: approval?
Flags: approval2.18?
Flags: approval2.18+
Flags: approval+
OS: Linux → All
Hardware: PC → All
Target Milestone: --- → Bugzilla 2.18
|
|
Assignee | |
Comment 4•21 years ago
|
||
Fixed on trunk and branch. Thanks.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
|
||
Comment 5•20 years ago
|
||
*** Bug 232661 has been marked as a duplicate of this bug. ***
|
||
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•