253008 - Set network.proxy.share_proxy_settings if IE has a single proxy set up.

Status: RESOLVED FIXED

(Firefox :: Migration, defect)

Description

[Mike Connor [:mconnor]]

If IE is using "use the same proxy for all protocols" we should set
network.proxy.share_proxy_settings to true, so that this is reflected in the
prefpanel.  As noted by shaver, we already detect this and expand out the
setting to the prefs.

this is a one-liner, patch upcoming.

Comment 1

[Mike Connor [:mconnor]]

Attachment: patch

Comment 2

[Mike Connor [:mconnor]]

Comment on attachment 154306 [details] [diff] [review]
patch

good idea.  As punishment, you can review this one-liner. :)

Comment 3

[Mike Shaver (:shaver emeritus)]

Comment on attachment 154306 [details] [diff] [review]
patch

Shouldn't we just set the single proxy entry, like the user would if she
checked the box?

Comment 4

[Mike Connor [:mconnor]]

no, because when the user checks the box, we actually copy the values to
ssl/ftp/gopher, so that necko still has the same prefs in place.  The prefpanel
change is cosmetic only and has no effect on what the backend expects in terms
of prefs.  In theory, we could make the new pref a necko pref and just use the
http pref for all cases, but I'm not sure that's necessary.  Might be worth
pinging darin about though.

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 154306 [details] [diff] [review]
patch

r=[e-mail]

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 154306 [details] [diff] [review]
patch

a=asa for branch checkin.

Comment 7

[Mike Connor [:mconnor]]

not a blocker, will try to get this in soon.

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 154306 [details] [diff] [review]
patch

need re-approval now that we're past 1.0 RC. setting back to request.

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 154306 [details] [diff] [review]
patch

a=asa for checkin to the aviary branch.

Comment 10

[Darin Fisher]

Comment on attachment 154306 [details] [diff] [review]
patch

sr=darin

Comment 11

[Steffen Wilberg]

Checked in branch & trunk.

Comment 12

[benc]

I'll try to verify this when I get a chance...