Closed Bug 253125 Opened 20 years ago Closed 14 years ago

cleanup gratuitous use of NS_ERROR_FACTORY_REGISTER_AGAIN

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: darin.moz, Unassigned)

References

(
URL
)

Details

(Keywords: helpwanted) 

cleanup gratuitous use of NS_ERROR_FACTORY_REGISTER_AGAIN.  nsSample.js throws
NS_ERROR_FACTORY_REGISTER_AGAIN from registerSelf for no apparent reason other
than to demonstrate that it is possible to do so.  The comments should be
improved to explain that this is an optional feature of component registration.
 Because no such comments exist, other JS components appear to have copied the
pattern.  In many cases it is unnecessary overhead.

throwing NS_ERROR_FACTORY_REGISTER_AGAIN has the effect that:

<shaver> rather: you will be called again _if_ another component is registered

so, there's also a subtle bug in the implementation since it's possible that no
other component is ever registered.
Keywords: helpwanted
Target Milestone: --- → Future
Assignee: darin → nobody
QA Contact: xpcom
Target Milestone: Future → ---
All of the programmatic registration code is gone, long live manifests!
Status: NEW → RESOLVED
Closed: 14 years ago
status2.0: ? → ---
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.