253242 - Reduce footprint for Mozilla Suite help guide

Status: VERIFIED FIXED

(Documentation Graveyard :: Help Viewer, defect)

Description

[Giacomo Magnini]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040620
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040620

By simply removing unused images and converting them to other formats, we could
save around 30K (on 96K). This can be accomplished in two steps:
1) Remove unused image files
2) Optimize (or convert) the remaining png files and fix the references in the
xhtml files.


Reproducible: Always
Steps to Reproduce:




There are many mage files which are not used by the help system, and can be
removed safely:
flag.gif
flag_column.gif
help_nav.gif
help_print.gif
mailicon.gif
newmailicon.gif
read.gif
read_column.gif
taskbar.png
taskbar-ab.gif
unread.gif (*)
This will save more than 17KB.

(*) this is referenced in xpinstall/packager/packages-mac, line 300: should a
patch for that be needed?
Patch coming up...

Comment 1

[Giacomo Magnini]

Attachment: Patch to remove unused images from the distribution

Once committed, the image files should be cvs removed: I'm not sure on how to
do this.

Comment 2

[R.J. Keller]

--> giacomo.magnini

Comment 3

[Giacomo Magnini]

Does this need sr?
Also,  don't have checkin rights, so rj could you please check it in when all 
is set?
TIA, Giacomo.

Comment 4

[Giacomo Magnini]

Comment on attachment 154446 [details] [diff] [review]
Patch to remove unused images from the distribution

Obsoleting, since help_nav and help_print gifs are being reintroduced as of bug
253163 . New patch coming up.

Comment 5

[Giacomo Magnini]

Attachment: Updated patch. Reintroduced help_nav.gif, help_print.gif (both used in help_help.xhtml) and taskbar.png (used in composer_help.xhtml).

Comment 6

[R.J. Keller]

Comment on attachment 155076 [details] [diff] [review]
Updated patch. Reintroduced help_nav.gif, help_print.gif (both used in help_help.xhtml) and taskbar.png (used in composer_help.xhtml).

r=[e-mail], looks good! No, super-review is not needed for Help. I'll
check this in once I get a tree.

Comment 7

[R.J. Keller]

Fix checked in.

Comment 8

[Giacomo Magnini]

Attachment: Some gif images (yesterday's optimized ones) converted to png to save space, with taskbar-ab.png added (used in mail_help.xhtml)

Comment 9

[Giacomo Magnini]

Attachment: Patch to use above png's instead of gifs.

The original gif files can be removed after png's are checked in.

Comment 10

[Giacomo Magnini]

Attachment: Opps! Fixed permission bits...

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 155158 [details] [diff] [review]
Patch to use above png's instead of gifs.

unsetting 1.8a3 approval request. we've shipped already.

Comment 12

[Giacomo Magnini]

No checkin rights. rjk, please?

Comment 13

[Giacomo Magnini]

Comment on attachment 155160 [details]
Opps! Fixed permission bits...

Obsoleting, since a few checkins bitrotted the patch, and I've found 2 more
images which were wrongly removed. New patch and new list of files to delete
coming soon.

Comment 14

[Giacomo Magnini]

Attachment: Some images translated to PNG format

Some images translated to png format, and added back mail_flag.png,
mail_flag_column.png and taskbar-ab.png which were accidentally removed, but
still used. These images total 44449 bytes. After checking those in, the images
in the list below can be removed (totalling 56461 bytes), saving around 12Kb
and obtaining complete docs (that is, showing correct images, all of them).
Files to be removed after checkin:
composer_icon.gif
help_nav.gif
locationbar.gif
personalbar.gif
search.gif
searchmusic.gif
sidebarclosed_small.gif
tabbed_browsing_bar.gif

Comment 15

[Giacomo Magnini]

Attachment: Updated patch, added back mail_flag.png, mail_flag_column.png and taskbar-ab.png which are still used.

Here is the updated patch. I've added back the images used and accidentally
removed, and reordered the filenames in jar.mn. It includes also fixed image
references into the help files (touched only composer_help, customize_help,
help_help and nav_help).

Comment 16

[R.J. Keller]

Comment on attachment 157257 [details] [diff] [review]
Updated patch, added back mail_flag.png, mail_flag_column.png and taskbar-ab.png which are still used.

Neil, can you pick these up for me? Thanks!

Comment 17

[[e-mail]]

Comment on attachment 157257 [details] [diff] [review]
Updated patch, added back mail_flag.png, mail_flag_column.png and taskbar-ab.png which are still used.

I checked in everything except the tabbed browsing bar, which my graphics
package said was different.

Comment 18

[Giacomo Magnini]

Attachment: Updated tabbed_browsing_bar.png

Don't know what was wrong with the previous image. Again, this is a straight
conversion to png format (PSP8). Neil, could one check this in and backout your
change to jar.mn (1.64 I think)? This will finally fix all of the docs, and the
bug can be closed as well.

Comment 19

[[e-mail]]

Comment on attachment 157302 [details]
Updated tabbed_browsing_bar.png

Sorry, this is still computing as different. (In case you're wondering, I can't
rely on visual inspection because I'm using 256 colour video).

Comment 20

[Giacomo Magnini]

Attachment: Third attempt

Another attempt at converting the image...
The same named gif should be then removed from cvs (if I finally got this
right!).
Sorry for wasting everybody's time...

Comment 21

[[e-mail]]

Fix checked in.

Comment 22

[Jeff Walden (gone starting June 8)]

Comment on attachment 157256 [details]
Some images translated to PNG format

I'm not sure I have either the knowledge or the time to review this.  If it
needs to be done, someone else will have to do it, because I'm swamped with a
ton of things right now and can't do this.

Comment 23

[Giacomo Magnini]

These updates have been already checked into mozilla seamonkey tree. Are you
planning to ship these into FX??? I tought the images were totally different. I
don't understand what's going on...

Comment 24

[Stefan [:stefanh]]

I'm verifying this. However, I still see some unused images in the image dir.
Will open a new bug instead ;)