25330 - jsps... Appending data rather than replacing it.

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[anne dirkse]

If you go to the URL above and click on the Execute button for the Numberguess
example, the ordinary behavior(at least for Navigator 4x and Inept Explorer) is
to replace the query string appended to the URL with each submission.  Mozilla
5.0 is never getting rid of the old data.

(Note:  the page is the standard example page for the apache/jakarta
tomcatserver -- the
sourcefortheexampleisavailablenexttothepage.AndThisFormIsn'tLettingMeTypeSpacesAnyMoreSorry!)

Comment 1

[Stuart Ballard]

[Just a little more detail from someone else who noticed this bug... ie me :) ]

I see this behavior when a form has method=get (or method defaulting to get) and
*no* action, *and* the page containing the form has parameters of its own. The
correct behavior is to take the URL of the page containing the form, _remove any
existing parameters_, and then add the parameters based on the values in the
form. This second step (the one between __s) is the one that mozilla is leaving
out.

Also, this bug appears to have nothing to do with JSP, as I am seeing it in a
CGI application. It's just to do with the lack of an explicit action url and the
presence of parameters on the url of the page containing the form. I recommend
changing the summary to reflect this (I couldn't get to the URL specified for
this bug, so someone else will need to confirm that the form does indeed have no
action specified).

I am using a Linux M13 build, but I would guess this bug is XP.

Hope this information helps.

Comment 2

[karnaze (gone)]

Reassigning to Eric.

Comment 3

[Eric Pollmann]

This is really related to bug 23376.  I decided to append variables, guessing
nobody would depend on the "replace" behaviour.  I see how this behaviour is
just plain wrong now.  :)  I'll change to replace as Nav and IE do.

Comment 4

[Eric Pollmann]

Just to clarify, there are two things I'm talking about here:

a) URL of CGI is http://foo.bar.baz/bi.cgi?bim=bop"
   Page contains <FORM> (no action specified)
b) Page contains <FORM ACTION="http://foo.bar.baz/bi.cgi?bim=bop">

In case a), we should definitely axe the bim=bop.
In case b) it's not so clear.  I'll use my reasoning in bug 23376 to argue that
we should leave the variables in place.  Sound okay?

Comment 5

[anne dirkse]

sounds good to me!

Comment 6

[Stuart Ballard]

Sounds good to me too. Keep up the good work guys! :)

Comment 7

[Eric Pollmann]

See related bug 27006 and bug 26917.

Comment 8

[Eric Pollmann]

Attachment: Test case

Comment 9

[Eric Pollmann]

Fix checked in.  To verify, view the above test case. Clicking on the Submit
button should cause a Bad Bug ID errror.  The "attach_id=6923" at the end of the
URL in the URL bar should be replaced with "Sub=Dimension".  Thanks!

Comment 10

[Vladimir Ermakov]

Updating QA contact.

Comment 11

[Vladimir Ermakov]

Verifying on 
 -Windows 98 build 2000-09-25-08-M18
 -Linux RedHat6.2 build 2000-09-19-21-M18