253326 - Popup blocked information bar should be closeable

Status: VERIFIED FIXED

(Firefox :: General, enhancement, P2)

Description

[zenervation]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040725 Firefox/0.9.0 (bangbang023)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040725 Firefox/0.9.0 (bangbang023)

When you go to a site which is blocked from opening a popup window, the bar
which appears notifying you should be closeable. I, among a lot of people, value
browsing space very highly (I keep all toolbars on the menu bar), and so being
able to close that bar once I've seen it would be very useful. I know there is
the option to never show the bar, but I like being able to see when popups are
blocked.

Reproducible: Always
Steps to Reproduce:
1. Go to a site which opens a popup window (e.g.
http://andy.tom-h.com/Misc/firefox_demo1.html)
2. The popup information bar opens

Actual Results:  
Popup information bar opens, only way of getting rid of it is to permanently
disable it.

Expected Results:  
There should be a close 'X' at the right of the bar (like the tabbar/FAYT bar).

Comment 1

[Fareed Rizkalla]

i agree

Comment 2

[Michael Lefevre]

I was just about to file a request for this myself. Confirming.

It's possible to get rid of it by switching to another tab and back, but it
would be nice to have a way to get back the screen real estate on pages with
popups, without disabling the feature completely, or tab-switching workarounds.

Comment 3

[Michael Lefevre]

and now they've gone and fixed the tab switch bug that allowed a workaround :P

Comment 4

[zenervation]

Flagging blocking-aviary1.0?

When Firefox 1.0 gets reviewed by all sorts of people, it's highly obvious
annoyances like this that will bring opinions down.

Comment 5

[Blake Ross]

-> ben

Comment 6

[Eldo Varghese]

why isnt this bug displayed as fixed

Comment 7

[zenervation]

...because it's not fixed? (that was a rhetorical question, it isn't fixed)

Comment 8

[GerbenW]

I agree.

However, i'd like to see this go a bit further.
How about an option like: 'never show the pop-up block message for this site again'

Comment 9

[zenervation]

(In reply to comment #8)
> I agree.
> 
> However, i'd like to see this go a bit further.
> How about an option like: 'never show the pop-up block message for this site
again'

In fact, this be further improved on. How about 'never show this message again
for this popup'. (Because on some sites, you may want to permanently forget
about a particular advertising popup, but you still want to know if it tries to
open something else because it may be something useful)

Comment 10

[Johnny Stenback (:jst)]

Doron wrote code to make such a bar closeable for the plugin bar, maybe there's
a trivial patch that would show a close button ('x') in the corner of this bar
too. If so, I'd be interested in taking that for 1.0. Doron, any chance you
could come up with a patch for this?

Let's keep further requests for other improvments to this bar in other bugs (new
ones if such bygs don't exist yet).

Comment 11

[Asa Dotzler [:asa]]

Thanks for the report, Andy, and the nomination. This is something we probably
need to address for the Firefox 1.0 release but I think we're going to be
shipping it as is in the Preview Release. I've set the blockingPR flag to minus
and the blocking1.0 flag to plus to note this plan.

Comment 12

[Doron Rosenberg (IBM)]

Right, the patch is trivial (change an false argume to true).  I'll post a patch
once my cvs checkout finishes.

Comment 13

[Doron Rosenberg (IBM)]

Attachment: Patch

Not as trivial as I thought, because the way popup context windows in the
message bar is funky code.

Comment 14

[Asa Dotzler [:asa]]

Comment on attachment 158784 [details] [diff] [review]
Patch

let's get review before considering for approval.

Comment 15

[:Gavin Sharp [email: [e-mail]]]

Superreview isn't necessary for checkins to browser or toolkit.
http://www.mozilla.org/projects/firefox/review.html

Comment 16

[Doron Rosenberg (IBM)]

Comment on attachment 158784 [details] [diff] [review]
Patch

Asa - bug has r=mconner already. Renominating.

Comment 17

[Michael Lefevre]

Doron: I pointed that out to Asa on IRC - he was aware of the review, but
pointed out that you've requested a sr from Ben, which you don't have.

Comment 18

[:Gavin Sharp [email: [e-mail]]]

You can just remove the sr request, unless you actually wanted ben to take a look.

Comment 19

[Asa Dotzler [:asa]]

Comment on attachment 158784 [details] [diff] [review]
Patch

I don't believe we're taking major feature behavior changes without getting
Ben's OK first. Get Ben to OK this with sr= or a=.

Comment 20

[Ben Goodger (use ben at mozilla dot org for email)]

Will look tomorrow. 

Comment 21

[chris hofmann]

bugs without priority sometimes don't make it on ben's queries..  adding priority

Comment 22

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 158784 [details] [diff] [review]
Patch

r+a=[e-mail]

Comment 23

[Doron Rosenberg (IBM)]

checked in.

Comment 24

[sairuh (rarely reading bugmail)]

vrfy'd fixed with 200410150x-0.9+ builds on linux fc2 and mac os x 10.3.5.