253360 - IF() should be replaced by CASE WHEN

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Tomas Kopal]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.1) Gecko/20040721 Debian/1.7.1-2
Build Identifier: 

As IF(cond, exp1, exp2) function is MySQL specific, we should replace it with
CASE WHEN cond THEN exp1 ELSE exp2 END, which is supported by all major
databases (see bug 182136).
The patch will follow

Reproducible: Always
Steps to Reproduce:

Comment 1

[Dave Miller [:justdave]]

Since when does MySQL support it?

Comment 2

[Tomas Kopal]

Attachment: Patch replacing IF() with CASE WHEN

Comment 3

[Tomas Kopal]

"CASE was added in MySQL 3.23.3"  (see
http://dev.mysql.com/doc/mysql/en/Control_flow_functions.html). I think we
currently require 3.23.3 or higher, right?

Comment 4

[Dave Miller [:justdave]]

yeah, just found that in the changelog myself before coming back here.  How
interesting.

Yes, we currently require 3.23.41 or newer, so that shouldn't be a problem at all.

(Although I do think IF() is easier to read, but compatibility rules...)

Comment 5

[Vlad Dascalu]

Checking in editgroups.cgi;
/cvsroot/mozilla/webtools/bugzilla/editgroups.cgi,v  <--  editgroups.cgi
new revision: 1.41; previous revision: 1.40
done
Checking in editusers.cgi;
/cvsroot/mozilla/webtools/bugzilla/editusers.cgi,v  <--  editusers.cgi
new revision: 1.68; previous revision: 1.67
done
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.211; previous revision: 1.210
done