Closed Bug 253364 Opened 20 years ago Closed 20 years ago

remove unconditional MarkDirty in nsBoxFrame::AttributeChanged

Categories

(Core :: XUL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.8alpha3

People

(Reporter: dbaron, Assigned: dbaron)

Details

(Keywords: perf, Whiteboard: [patch])

Attachments

(1 file, 1 obsolete file)

The first step towards cleaning up XUL / box attribute -> style mapping is
removing the unconditional MarkDirty from nsBoxFrame::AttributeChanged so we at
least learn if it's covering anything up.  So far I haven't noticed any
problems.  This actually may improve performance doing things like mousing over
menus.
Status: NEW → ASSIGNED
Whiteboard: [patch]
Target Milestone: --- → mozilla1.8alpha3
Attachment #154543 - Flags: superreview?(roc)
Attachment #154543 - Flags: review?(bryner)
Attachment #154543 - Flags: review?(bryner) → review+
Attachment #154543 - Flags: superreview?(roc) → superreview+
Attached patch patchSplinter Review
I've been running with this for months, but I just realized that it's what
broke progressmeter for me.  And I put XXX comments in the other things it may
have broken.
Attachment #154543 - Attachment is obsolete: true
Fix checked in to trunk (with just nsProgressMeterFrame changes added),
2004-09-17 11:36 -0700.

There's really no reason to think that the specific attributes already handled
in AttributeChanged methods in some way are the ones that are going to cause
regressions.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Keywords: perf
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: