253489 - [FIX]Eliminate mCharset member of prescontext

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Boris Zbarsky [:bzbarsky]]

> Well, there are two codepaths that set mCharset
> the first sets it to the charset of the document
> The second is nsPresContext::Observe
> That's the document charset observer shit
> So we have the identity mShell->GetDocument()->GetDocumentCharacterSet() ==
  mCharset

And hence no need of this member.  SetBidi is the one place that needs it, and
that's not performance-critical.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 155188 [details] [diff] [review]
Patch

roc, would you review?

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 155188 [details] [diff] [review]
Patch

-    mShell->SetPreferenceStyleRules(PR_TRUE);
+    mShell->SetPreferenceStyleRules(PR_FALSE);

What's this about? Is it a stray hunk from some other patch?

Other than that, it looks fine.

Comment 4

[Boris Zbarsky [:bzbarsky]]

> What's this about? Is it a stray hunk from some other patch?

Yes, it is.  I'll make sure not to check it in.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Fixed.