[FIX]Eliminate mCharset member of prescontext

RESOLVED FIXED in mozilla1.8alpha3

Status

()

Core
Layout: Misc Code
P3
normal
RESOLVED FIXED
14 years ago
4 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

Trunk
mozilla1.8alpha3
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

> Well, there are two codepaths that set mCharset
> the first sets it to the charset of the document
> The second is nsPresContext::Observe
> That's the document charset observer shit
> So we have the identity mShell->GetDocument()->GetDocumentCharacterSet() ==
  mCharset

And hence no need of this member.  SetBidi is the one place that needs it, and
that's not performance-critical.
Comment on attachment 155188 [details] [diff] [review]
Patch

roc, would you review?
Attachment #155188 - Flags: superreview?(roc)
Attachment #155188 - Flags: review?(roc)
Priority: -- → P3
Summary: Eliminate mCharset member of prescontext → [FIX]Eliminate mCharset member of prescontext
Target Milestone: --- → mozilla1.8alpha3
Comment on attachment 155188 [details] [diff] [review]
Patch

-    mShell->SetPreferenceStyleRules(PR_TRUE);
+    mShell->SetPreferenceStyleRules(PR_FALSE);

What's this about? Is it a stray hunk from some other patch?

Other than that, it looks fine.
Attachment #155188 - Flags: superreview?(roc)
Attachment #155188 - Flags: superreview+
Attachment #155188 - Flags: review?(roc)
Attachment #155188 - Flags: review+
> What's this about? Is it a stray hunk from some other patch?

Yes, it is.  I'll make sure not to check it in.
Fixed.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.