253544 - Make private attachment activity log entries private as well

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Joel Peshkin]

Comment 1

[Joel Peshkin]

The log can show the when and who, but added/removed should be blanked at
display-time

Comment 2

[Joel Peshkin]

Do this in CGI.pm  in GetBugActivity

Comment 3

[Joel Peshkin]

Attachment: remove private attachment rows at display time

Comment 4

[Christian Reis]

You want people to mark r+ on patches with variables called $extra1 and $extra2?
Argh!

Comment 5

[Zach Lipton [:zach]]

Comment on attachment 154659 [details] [diff] [review]
remove private attachment rows at display time

>@@ -157,7 +157,7 @@
>     my $alias = $id;
>     if (!detaint_natural($id)) {
>         $id = BugAliasToID($alias);
>-        $id || ThrowUserError("invalid_bug_id_or_alias", {'bug_id' => $id});
>+        $id || ThrowUserError("invalid_bug_id_or_alias", {'bug_id' => $alias});
>     }
>     
>     # Modify the calling code's original variable to contain the trimmed,

Remove this since it doesn't belong in this bug (and has already been checked
in)

>+    my $extra1 = "";
>+    my $extra2 = "";
As kiko said, could these be somewhat more descriptive?

Comment 6

[Joel Peshkin]

Attachment: v2

Comment 7

[Zach Lipton [:zach]]

Comment on attachment 155244 [details] [diff] [review]
v2

r=zach

Comment 8

[Dave Miller [:justdave]]

holding approval for release day

Comment 9

[Dave Miller [:justdave]]

Checked in on trunk:

Checking in CGI.pl;
/cvsroot/mozilla/webtools/bugzilla/CGI.pl,v  <--  CGI.pl
new revision: 1.216; previous revision: 1.215
done

and 2.18 branch:

Checking in CGI.pl;
/cvsroot/mozilla/webtools/bugzilla/CGI.pl,v  <--  CGI.pl
new revision: 1.211.2.2; previous revision: 1.211.2.1
done

Comment 10

[Dave Miller [:justdave]]

advisory has posted, clearing security flag.