253916 - CTRL++ does not work if using "+=" key on UK keyboard (same issue as 238474)

Status: RESOLVED FIXED

(Toolkit :: View Source, defect)

Description

[Soothsayer]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040801 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040801 Firefox/0.9.1+

When in the view source window, CTRL++ only zooms text when using the "+" from
the numeric keypad. It does not work when using the "+=" key next to the backspace.

This problem is essentially a repeat of 238474. However, that bug requests that
a new one be opened if the problem continues.

Reproducible: Always
Steps to Reproduce:
1. Select View Page Source on any web page.
2. Press CTRL++ using the + next to the backspace - Nothing happens.
3. Press CRTL++ using the + on th enumeric keypad - The text zooms.

Actual Results:  
Nothing

Expected Results:  
The text in the page source window should have zoomed in.

Only tested with the UK keyboard layout.

Comment 1

[Raanan Barzel]

The French keyboard functions just like the UK keyboard.

Comment 2

[Adam Licata]

I'm also seeing this on my US keyboard.

Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.7) Gecko/20040714 Firefox/0.9.1+

Comment 3

[José Jeria]

Confirming, same thing with a swedish keyboard.

Comment 4

[R.J. Keller]

Attachment: Patch - Adds Ctrl + =

Thought I'd fix this bug real quick.

Comment 5

[R.J. Keller]

with the locale freeze, it's now or never, so recommending blocking-aviary1.0PR.
Usually I wouldn't recommend this for blocking, but if we're getting this in
then it needs to be now. Looks like this is fixed on the trunk.

Comment 6

[chris hofmann]

ben, blake, bsmedberg,  mconnor,

looks straight forward.  can you review and help to get this landed quickly?

Comment 7

[R.J. Keller]

mconnor: can you review this or should I send it to someone else?

Comment 8

[Mike Connor [:mconnor]]

Comment on attachment 156129 [details] [diff] [review]
Patch - Adds Ctrl + =

yeesh, sorry about latency

Comment 9

[amano]

Couldn't this patch be easily modified to fix the Ctrl-0 shortcut as well (it
doesn't work with the Num - "0" key)?

With a <!ENTITY textReset2.commandkey "Ins"> or something like that?

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 156129 [details] [diff] [review]
Patch - Adds Ctrl + =

a=[e-mail]

Comment 11

[R.J. Keller]

Fix checked in.

Comment 12

[Nick Thomas [:nthomas] (UTC+12)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20040902
Firefox/1.0 PR (NOT FINAL), from sweetlou tinderbox about 0900 GMT 20040902

The checkin for this bug has caused an error on "View Page Source": 

XML Parsing Error: undefined entity
Location: chrome://global/content/viewSource.xul
Line Number 60, Column 41:
  <key id="key_textZoomEnlarge2" key="&textEnlarge.commandkey2;"
command="cmd_txtZoomEnlarge" modifiers="accel"/>

This is because the files
  toolkit/components/viewsource/content/viewPartialSource.xul 
  toolkit/components/viewsource/content/viewSource.xul
refer to 
  textEnlarge.commandkey2

while the file
  toolkit/locales/en-US/chrome/global/viewSource.dtd
has
  textEnlarge2.commandkey

Comment 13

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: View source regression patch

Comment 14

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 157705 [details] [diff] [review]
View source regression patch

Sorry for bugspam, newbie alert.

Comment 15

[Wolf [:wolf]]

Reopening bug, since there's a regression and a patch attached to fix it. :-)

Comment 16

[Wolf [:wolf]]

Comment on attachment 157705 [details] [diff] [review]
View source regression patch

mconnor, mind reviewing this one line regression fix?

Comment 17

[R.J. Keller]

fix checked in

Comment 18

[Scott MacGregor]

cc'ing myself to track the regression