enablePrivilege dialog in Firefox is missing delay

RESOLVED FIXED

Status

()

Firefox
General
RESOLVED FIXED
14 years ago
13 years ago

People

(Reporter: Jesse Ruderman, Assigned: dveditz)

Tracking

({fixed-aviary1.0})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: security)

Attachments

(2 attachments)

(Reporter)

Description

14 years ago
 
(Reporter)

Updated

14 years ago
Whiteboard: security
(Reporter)

Comment 1

14 years ago
Created attachment 154934 [details]
a simple page that calls enablePrivilege
(Reporter)

Updated

14 years ago
Flags: blocking-aviary1.0?
(Reporter)

Comment 2

14 years ago
This hole is easy to discover because the testcase from bug 162020 uses
enablePrivilege.  We shouldn't rely on this bug remaining confidential until
September.
Flags: blocking-aviary1.0PR?

Comment 3

14 years ago
Created attachment 155742 [details] [diff] [review]
port commonDialog.js changes to toolkit

This patch is a straight port of the patches from bug 239580 and bug 162020. 
Neither correctly updated the toolkit\ version of commonDialog.js

Comment 4

14 years ago
Comment on attachment 155742 [details] [diff] [review]
port commonDialog.js changes to toolkit

Can we get this looked over quickly?
Attachment #155742 - Flags: review?(bugs)
Attachment #155742 - Flags: approval-aviary?
(Assignee)

Comment 5

14 years ago
Comment on attachment 155742 [details] [diff] [review]
port commonDialog.js changes to toolkit

r=dveditz
Attachment #155742 - Flags: review?(bugs) → review+
Comment on attachment 155742 [details] [diff] [review]
port commonDialog.js changes to toolkit

a=me, although I'd really prefer to see the countdown shown in some way, so
that the user doesn't immediately wonder what's happened...
Attachment #155742 - Flags: approval-aviary? → approval-aviary+
(Reporter)

Comment 7

14 years ago
I checked in Quark's patch, trunk and aviary.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Flags: blocking-aviary1.0PR?
Flags: blocking-aviary1.0?
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
(Reporter)

Comment 8

14 years ago
Quark filed bug 255279 for making the a countdown visible.
(Assignee)

Updated

13 years ago
Group: security
You need to log in before you can comment on or make changes to this bug.