253945 - enablePrivilege dialog in Firefox is missing delay

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Jesse Ruderman]

Comment 1

[Jesse Ruderman]

Attachment: a simple page that calls enablePrivilege

Comment 2

[Jesse Ruderman]

This hole is easy to discover because the testcase from bug 162020 uses
enablePrivilege.  We shouldn't rely on this bug remaining confidential until
September.

Comment 3

[Ryan Polk (Quark)]

Attachment: port commonDialog.js changes to toolkit

This patch is a straight port of the patches from bug 239580 and bug 162020. 
Neither correctly updated the toolkit\ version of commonDialog.js

Comment 4

[Ryan Polk (Quark)]

Comment on attachment 155742 [details] [diff] [review]
port commonDialog.js changes to toolkit

Can we get this looked over quickly?

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 155742 [details] [diff] [review]
port commonDialog.js changes to toolkit

r=dveditz

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 155742 [details] [diff] [review]
port commonDialog.js changes to toolkit

a=me, although I'd really prefer to see the countdown shown in some way, so
that the user doesn't immediately wonder what's happened...

Comment 7

[Jesse Ruderman]

I checked in Quark's patch, trunk and aviary.

Comment 8

[Jesse Ruderman]

Quark filed bug 255279 for making the a countdown visible.