25412 - Search button should be depressable

Status: VERIFIED FIXED

(SeaMonkey :: General, defect, P3)

Description

[Michael La Guardia]

The search button should look like a button.  It should have a mouseover and a
depressed state to it.

Comment 1

[Michael La Guardia]

adding polish keyword

Comment 2

[shuang (gone)]

reassign the bug to german who will work on this and pass it to don's team. cc 
don.

Comment 3

[german]

that's right, also a hover state should be added. Don, while somebody in your 
team is working on navigator.css, can you please add to the current code:
#search-button { 
	list-style-image:none;
	margin: 0px;
	margin-right: 2px;
	background-color: #99CCCC;
	border: 2px solid #99CCCC;
	-moz-border-radius: 4px;
} 
the following two states:

#search-button:hover { 
	background-color: #ccffff;
     padding: 1px;
	border: 1px outset #ccffff;
} 

#search-button:active { 
	background-color: #ccffff;
     padding-top: 2px;
	padding-left: 2px;
	padding-bottom: 0px;
	padding-bottom: 0px;
	border: 1px inset #ccffff;
}

Also the label Search should be all caps like so: SEARCH (change in 
navigator.dtd)

Thanks for pointing this out! 

Comment 4

[leger]

Moving all UE/UI bugs to new component: User Interface: Design Feedback
UE/UI component will be deleted.

Comment 5

[german]

nominating for beta1, this needs to be in before public consumption

Comment 6

[Phil Peterson]

PDT+ with the belief that this is really easy and safe.

Comment 7

[don]

I agree that it should have mouseover and dpressed behavior, but none of the
other toolbar buttons (i.e. back, forward, etc.) are "standard this way.  I'll
leave it to Ben to duke it out with German on this one. :-)

Comment 8

[leger]

Must get in fix by 02/23 please.

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

fixed. 

Comment 10

[Eli Goldberg]

Claudius, this is probably more your area than mine. If you're swamped, feel
free to push it back to me and I'll gladly do it.

Comment 11

[Claudius Gayle]

Assuming this is an XP thing:
I'm reopening for two reasons
1. I don't see the hover state that the above code describes.
2. Where's the border for active and inactive states?

Without these two things the button just shows the bonk (depressed) effect but it's kinda sad looking and does not match any of 
the other UI.
I'm looking at the 2000022509 linux build btw.

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

a hover effect for this type of button has not been described anywhere. 

Comment 13

[german]

Hover should be as described above: #search-button:hover { background-color: #ccffff; padding: 1px; border: 1px outset #ccffff;

Comment 14

[Ben Goodger (use ben at mozilla dot org for email)]

thanks.. will check in. 

Comment 15

[Claudius Gayle]

don't forget the borders as well.

Comment 16

[Ben Goodger (use ben at mozilla dot org for email)]

fix checked in...

Comment 17

[Claudius Gayle]

cc'ing german. German, could you take a quick look at this and verify that your changes were implemented just as you wanted?

Comment 18

[Claudius Gayle]

marking verified