254313 - context menu click on a bookmark doesn't have an option to copy a url to the clipboard

Status: VERIFIED FIXED

(Camino Graveyard :: Accessibility, enhancement)

Description

[Jon Stevens]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a3) Gecko/20040802 Camino/0.8+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a3) Gecko/20040802 Camino/0.8+

context menu click on a bookmark in 'bookmark bar' doesn't have an option to
copy a url to the clipboard

Reproducible: Always
Steps to Reproduce:

Comment 1

[Ludovic Hirlimann [:Usul]]

That's true also when editing bookmarks.
Changing to new, rfe and 1.0 target.

Comment 2

[Bruce Davidson]

Note that for the editing case this will be slightly improved when bug 155484
lands - you can then copy the bookmark and if you paste it into a program
expecting plain text you'll get the URL. We should probably still have the
context menu though.

Comment 3

[Bruce Davidson]

Taking this bug.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

See also bug 299799 for doing this for History (plus some other things).

Comment 5

[Chris Lawson (gone)]

Bruce, any progress on this? I can probably take it if you're too busy.

cl

Comment 6

[Chris Lawson (gone)]

Having heard nothing from Bruce since Monday, taking this and bug 299799.

cl

Comment 7

[Chris Lawson (gone)]

Attachment: pizzatch, revision 1

Comment 8

[Chris Lawson (gone)]

Attachment: version 2, now without debug code

Also restores a couple indents that Simon said were intentional. Sorry 'bout that.

cl

Comment 9

[Simon Fraser [no longer active]]

Comment on attachment 205282 [details] [diff] [review]
version 2, now without debug code

>Index: BookmarkViewController.mm
>===================================================================


>+- (void) copyBookmarksURLs:(NSArray*)bookmarkItemsToCopy toPasteboard:(NSPasteboard*)aPasteboard
>+{
>+  // handle URLs, and nothing else, for simplicity.
>+  [aPasteboard declareTypes:[NSArray arrayWithObject:kCorePasteboardFlavorType_url] owner:self];
>+
>+  NSMutableArray* urlList = [NSMutableArray array];
>+  for ( unsigned int i = 0; i < [bookmarkItemsToCopy count]; ++i ) {

An enumerator would be cleaner here, if you want to attach a new patch?

Comment 10

[Chris Lawson (gone)]

Attachment: fixes Simon's comments

This patch contains a partial fix for bug 319491 as well; the rest of that patch can be found in that bug.

I wasn't sure how to split up the patch properly, since both bugs require modifications to the same file.

cl

Comment 11

[Simon Fraser [no longer active]]

In on trunk and branch.