254347 - Use of uninitialized value msg in query.cgi

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Jon]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030630 Galeon/1.3.8
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030630 Galeon/1.3.8

The apache error log has the following message:

query.cgi: Use of uninitialized value in string eq at
/var/www/html/bugzilla-cvs/query.cgi line 417.


Reproducible: Always
Steps to Reproduce:
1.do an advanced search query
2.select "Edit Search" at the bottom of the buglist
3.

Actual Results:  
error msg about "Use of uninitialized value" generated in the apache error log


Expected Results:  
no msgs in apache error log

Comment 1

[Marc Schumann [:Wurblzap]]

I can reproduce this if I turn cookies off and delete any saved DEFAULTFORMAT
cookie.

There is a check to set the default page to "specific" if no format is provided,
but this doesn't allow for the case of a set param('query_format') and an unset
param('format'). So, if I re-edit a search, the warning is issued.

Comment 2

[Jon]

I have cookies turned on and there is an entry listed in my cookie file as follows

machine.domain.company.com	FALSE	/bugzilla-cvs/	FALSE	2145916801	DEFAULTFORMAT
advanced

Comment 3

[Frédéric Buclin]

Attachment: patch, v1

We don't need to update the cookie if $vars->{'format'} is undefined.

Comment 4

[Max Kanat-Alexander]

Checking in query.cgi;
/cvsroot/mozilla/webtools/bugzilla/query.cgi,v  <--  query.cgi
new revision: 1.141; previous revision: 1.140
done