254381 - .ico and .xbm extensions should be listed in ALL Open File dialoges

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[Jonathan Watt [:jwatt]]

Spinning this off from bug 214968 and CCing everyone who was CCed on that bug. 

Mozilla and Firebird are capable of opening bitmap and icon files, and the .bmp,
.ico and .xbm extension should be included in the "Image Files" option of the
Open File dialog boxes. I'll deal with Firefox first to try and get these
changes in before the PR.

Comment 1

[Ali Ebrahim]

Removing .bmp from summary since that's already there now.

Also, if we want to do this, we need to get it in before 1.0PR because this
impacts l10n.

This is not a 1.0PR blocker, but if it's going to be in Firefox 1.0, it needs to
get fixed now-ish.

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: patch for aviary

Here's my suggested patch for Firefox. I've put the extensions roughly in order
of how common they are. Does anyone know who updates the following files, and
assuming this patch gets in for Firefox 1.0, will the changes be reflected in
the localized builds for these locals? Or do I need to get someone to do that? 


mozilla/toolkit/locales/nb-NO/chrome/global/filepicker.properties
mozilla/toolkit/locales/sl-SI/chrome/global/filepicker.properties

Comment 3

[Jonathan Watt [:jwatt]]

Comment on attachment 155246 [details] [diff] [review]
patch for aviary

mconnor can you review for
mozilla/toolkit/locales/en-US/chrome/global/filepicker.properties
neil can you review for
mozilla/xpfe/components/filepicker/res/locale/en-US/filepicker.properties
whoever reviews last can you mark asa down for		approval-aviary please

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 155246 [details] [diff] [review]
patch for aviary

a=asa for aviary checkin.

Comment 5

[Jonathan Watt [:jwatt]]

Checked in on trunk and branch.