254548 - walla.co.il - uses propriatary javascript

Status: RESOLVED DUPLICATE of bug 281825

(Tech Evangelism Graveyard :: Hebrew, defect)

Description

[Tsahi Asher]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; he-IL; rv:1.7) Gecko/20040616
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; he-IL; rv:1.7) Gecko/20040616

several things are broken in walla's new 1GB mailbox:
1. you can't send email. pressing the "send" button in the toolbar does nothing.
as far as i could see, this is controlled by the following function:
function wm_handleSend(type) {
var i,cattach,sattach="";
send_submitted=1;
if (attach_uploading==1) return;
if (document.msgform.attach.value!="") {setTimeout(wm_submitAttach,10);   return;}
if (address_checked==0) {setTimeout(wm_addrCheck,10); return;}

if (submitted==0) {
   submitted=1;
   for (i=0;i<attaches.num;i++) {
      cattach=attaches[i];
      sattach=sattach+cattach.ct+"|"+cattach.id+"|"+cattach.name+"||";
      document.msgform.attachments.value=sattach;
      }

   document.msgform.html_enable.value=walla_editor;
   if (type==2) document.msgform.draft.value=1;
   if (walla_editor==1) {
      document.msgform.htmlMessage.value=editor_get_html();
      document.msgform.textMessage.value=editor_get_text();
      }
   document.msgform.w.value="/@compose.commit";
   document.msgform.target="_self";
   document.msgform.submit();
   }
}
the form "document.msgform..." is invalid.

2. you can't attach files. pressing the attach button sends you back to the
inbox folder. this is controlled by this function:
function wm_submitAttach() {
if (document.msgform.attach.value=="") return;
attach_uploading=1;
document.all("UPLOAD_PH").innerHTML='<iframe id="UPLOAD1091786866"
name="UPLOAD1091786866" width=1 height=1></iframe>';
document.msgform.w.value="/@attach.commit";
document.msgform.target="UPLOAD1091786866";
document.all("gAttachBrowse").style.display="none";
document.all("gAttachUploading").style.display="block";
document.msgform.submit();
}

uses document.all and other creatures.

3. selecting the checkbox to select all messages in the folder doesn't work.
this is controlled by this little fella:

function wm_sall(chk) {
  for (i=0;i<msgs_num;i++) {
    document.all("m["+i+"]").checked=chk;
    wm_s(i,chk);
  }
}

again, uses document.all.

there are other features that use such propriatary code.

Reproducible: Always
Steps to Reproduce:
1.if you don't have a walla accound already, get one at
http://friends.walla.co.il/ts.cgi?tsscript=reg&
2. go to newmail.walla.co.il
3. try to use any of the featurs i mentioned

Actual Results:  
they don't work, as described

Expected Results:  
considering how they are written, it is quite expected that they won't work. the
site should be rewritten to use document.getElementById() in order to support
mozilla and IE6.

Comment 1

[Tsahi Asher]

i sent them an evangelism letter.

Comment 2

[Felix Miata]

Conforming summary to TFM item 10 at 
http://www.mozilla.org/projects/tech-evangelism/site/procedures.html#file-new

Comment 3

[Niro]

Here is a Greasemonkey script that makes wallamail compatible with Firefox:
http://userscripts.org/scripts/show/3649
Works fine.

Comment 4

[Alexander Winston]

This is a duplicate of bug 281825

Comment 5

[Andrew Schultz]

yup.  resolving as such.