254662 - "don't exit" dialog boxes exits anyway

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Vince LaMonica]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040803 Firefox/0.9.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040803 Firefox/0.9.3

After upgrading to 0.9.3, I went to the above URL to re-download the googlebar
extension. Extension Manager opened, and stated "waiting" as the status. I
closed the extension manager window and then accidently closed the main firefox
window. A dialog box popped up warning me that i was downloading 1 file, and i
wanted to cancel the download and exit or 'don't exit'. I clicked don't exit,
but Firefox exited anyway. A restart of Firefox revealed that the googlebar had
not yet been downloaded. 

Reproducible: Always
Steps to Reproduce:
1.download an extension that might take a while to download
2.exit firefox/extension manager
3.click on "don't exit" in the popup window that appears
4. firefox will exit anyway. :(

Actual Results:  
Firefox exited.

Expected Results:  
Firefox should have kept the window open that I accidently closed - or at the
very least, brought up a new firefox window w/ my home page. "Don't exit"
usually means to me that the program won't exit. :-)

default theme, fresh 0.9.3 install [uninstalled the previous version as per the
docs]. I did import my previous [0.8] firefox prefs/bookmarks when prompted to
do so by firefox 0.9.3. I also customized the toolbar to include the 'new tab',
'print', and 'bookmarks' buttons.

Comment 1

[Francois Ingelrest]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040806
Firefox/0.9.1+

Same here, "don't exit" seems not to work.

Comment 2

[Asa Dotzler [:asa]]

This sounds like something that recently regressed. Ben or blake, can one of you
take a look at this? 

Comment 3

[chris hofmann]

lets get this by 1.0

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

don't bungle use of nsIPromptService API