editproducts generates warnings in error log

RESOLVED FIXED in Bugzilla 2.20

Status

()

--
trivial
RESOLVED FIXED
14 years ago
6 years ago

People

(Reporter: bugreport, Assigned: bugzilla)

Tracking

2.19
Bugzilla 2.20
Bug Flags:
approval +

Details

Attachments

(1 attachment)

(Reporter)

Description

14 years ago
TestProduct returns an undef if a product is not already degfined. So, when you
create a new product///


    my $existing_product = TestProduct($product);

    # Check for exact case sensitive match:
    if ($existing_product eq $product) {

causes a warning...

editproducts.cgi: Use of uninitialized value in string eq at
/home/bugzilla/head/editproducts.cgi line 438
(Assignee)

Comment 1

14 years ago
My fault, from bug#86051, I think
Assignee: justdave → bugzilla
(Assignee)

Updated

14 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 2

14 years ago
Created attachment 155961 [details] [diff] [review]
fix the undefined warning
(Assignee)

Updated

14 years ago
Attachment #155961 - Flags: review?

Updated

14 years ago
Target Milestone: --- → Bugzilla 2.20

Updated

14 years ago
Attachment #155961 - Flags: review? → review+

Updated

14 years ago
Flags: approval?
Flags: approval? → approval+

Comment 3

14 years ago
Checking in editproducts.cgi;
/cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v  <--  editproducts.cgi
new revision: 1.60; previous revision: 1.59
done
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.