254804 - Custom Mailview creation problems

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Mike Cowperthwaite]

Trying to create custom mailviews, particularly when also adding a new custom 
header, is difficult because of a balky UI.  Some of these problems are shared 
when adding a custom header via Message Filters or Message Search.

From the MailView dropdown, select Customize, then New.
Give the view a name, then in the header dropdown select Customize.
Type four new header names, click Add after each one.
* Actual result (1): Half of the new headers added are not (visibly) selected 
after the Add, nor (visibly) selectable from within the listbox; if the new 
header's position is even, it is preselected and reselectable.  Note that after 
entering several new headers, the focus can be placed on the listbox and 
scrolling thru the items with the arrow keys will apparently invisibly select 
the unselectable items.  (This result is seen when editing Message Filters or 
adding a custom header from Message Search, as well.)

Click OK.
* Actual result (2): header dropdown reads "Customize" instead of the new 
header. (This is unlike the behavior of the similar dialog when editing 
Message Filters/Message Search, but see bug 107604.)

Open the dropdown to select the new header
* Actual result (3): dropdown does not have the new header in place!
(This is not the case when editing Message Filters or Message Search.)

Do not change selection, click OK
* Actual result (4): no error is given for having "Customize" selected.

Select view in viewlist; click Edit
* Actual result (5): presents Customize Header dialog, rather than the Message 
View Setup dialog.

Click Cancel.  Message View Setup is displayed; dropdown still reads 
"Customize".  Open the dropdown now, and the new header is available.
Select the new header; if desired, add a value to the criterion box; click OK.
* Actual result (6): *sometimes* the new view is not selected or selectable in 
the Customize Message Views listbox; othertimes, it is preselected and 
reselectable.  Again, I haven't found the key to reproducing this reliably.
(Not applicable to Search.  In Filters, a new filter is always selectable but 
not preselected: bug 198597.)

Expected results:
(1) Every new header is shown selected in the list (and the list autoscrolled to 
make the new header visible) after clicking Add
(2 & 3) Dropdown is updated to include all the new headers in the dropdown list, 
and automatically selects whichever one was selected when the Ok button was 
clicked.
(4 & 5) Should never be possible: the dropdown should never read "Customize" if 
the Customize Headers dialog is not open, per previous expectation.
(6) similar to (1) -- Every time a view is added, it should be automatically and 
visibly selected.

Results seen with 1.7Final and 1.8a3-0806, Windows 2000.

Comment 1

[Scott MacGregor]

Attachment: the fix

nice find Mike

Comment 2

[Scott MacGregor]

i can't check this into the trunk because it's closed. 

Comment 3

[Mike Cowperthwaite]

Well, the big problem with this has been fixed: for Actual Result (2), the 
header dropdown now always resets to Subject when the Customize Headers window 
closes.  This isn't the *expected* result -- it neither selects whichever header 
was selected when that dialog was closed, nor whichever the selected entry was 
prior to selecting 'customize' from the list, but it's arguably correct, avoids 
the problems of symptoms (4) and (5) and also fixes symptom (3).

However, symptoms (1) and (6) are still extant.  I'll open a new bug for that.