254838 - Use @mozilla.org/moz/jssubscript-loader;1 as a singleton

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[timeless]

while only 1 of 4 public consumers uses it as a service, it has no state and
there's no reason to create more than one.

nb, i need to change my own consumers.

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Patch v.1

timeless: So you mean something like this?

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 155561 [details] [diff] [review]
Patch v.1

extensions/irc/xul/content/static.js
+	 if ((cls = Components.classes[LOADER_CTRID]))	    

please don't add trailing whitespace

Comment 3

[[e-mail]]

Comment on attachment 155561 [details] [diff] [review]
Patch v.1

sr=me if you fix the whitespace biesi pointed out and get some real moa.

Comment 4

[Frank Wein [:mcsmurf]]

Can i have your ok for this patch (it touches /mail)?

Comment 5

[Frank Wein [:mcsmurf]]

Attachment: Patch v.2

Final patch with correct whitespace

Comment 6

[Scott MacGregor]

Comment on attachment 155561 [details] [diff] [review]
Patch v.1

moa for the mail change

Comment 7

[Frank Wein [:mcsmurf]]

Comment on attachment 155964 [details] [diff] [review]
Patch v.2

carrying reviews over

Comment 8

[Frank Wein [:mcsmurf]]

Can i have your ok for this patch (it touches extensions/irc/)?

Comment 9

[James Ross]

(In reply to comment #8)
> Can i have your ok for this patch (it touches extensions/irc/)?

Yeah, r=me on the extensions/irc change.

Comment 10

[timeless]

Comment on attachment 155964 [details] [diff] [review]
Patch v.2

mozilla/mail/extensions/newsblog/js/newsblog.js 	1.22
mozilla/extensions/venkman/resources/content/venkman-commands.js	1.40
mozilla/extensions/irc/xul/content/static.js	1.112

Comment 11

[Frank Wein [:mcsmurf]]

fixed then