254880 - (regression in 1.7.2) pictures in table are not updated after changing them in mail editor after "edit as new" with HTML mail

Status: RESOLVED WORKSFORME

(MailNews Core :: Composition, defect)

Description

[Markus Merz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.2) Gecko/20040803
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.2) Gecko/20040803

I send an HTML email which contains a simple 3x2 table. Inside each cell I
position a picture with "Insert/Image ...". I send the mail, everything works fine.

The *regression* is that I can not see the new content in mail_composer after I
did a "edit as new ..." and changed all pictures.

Testcase
1. copy & paste the simple source from below to Mozilla composer "source code"
2. copy & paste from Mozilla composer "normal" to mail
3. send mail
4. edit the just sent mail as new
5. double click on Mozilla icon
6. replace Image Location with FF icon http://www.mozilla.org/images/ico-ff.png and 
7. The regression is happening in front of your eyes :-)

<table align="center" border="1" cellpadding="2" cellspacing="2"
width="85%">
<tbody>
<tr>
<td align="center" valign="top"><img alt=""
src="http://www.mozilla.org/images/ico-moz-m.gif" height="34"
width="34"><br>
</td>
<td align="center" valign="top"><img alt=""
src="http://www.mozilla.org/images/ico-moz-m.gif" height="34"
width="34"></td>
<td align="center" valign="top"><img alt=""
src="http://www.mozilla.org/images/ico-moz-m.gif" height="34"
width="34"></td>
</tr>
<tr>
<td align="center" valign="top"><img alt=""
src="http://www.mozilla.org/images/ico-moz-m.gif" height="34"
width="34"></td>
<td align="center" valign="top"><img alt=""
src="http://www.mozilla.org/images/ico-moz-m.gif" height="34"
width="34"></td>
<td align="center" valign="top"><img alt=""
src="http://www.mozilla.org/images/ico-moz-m.gif" height="34"
width="34"></td>
</tr>
</tbody>
</table>


Reproducible: Always
Steps to Reproduce:
1. I send an HTML email which contains a simple 3x2 table. Inside each cell I
insert a picture with the "Insert/Image ..." dialogue. I send the mail,
everything is OK.

2. I do an "edit as new" with the mail I just sent. I exchange the embedded
pictures in each cell against other pictures with the "Insert/Image ..."
dialogue. In the dialogue the new pictures are shown correctly. I OK the dialogue.

3. (regression in 1.7.2) The table content is not updated

4. If I save the content and open the draft I see the new pictures.

(Off topic) After step 4 my personal problem is, that I can not just copy the
table to paste it to my newsletter web archive anymore. When saving the draft
the pictures are are saved as inline content and I have to set all paths again
in composer.

Actual Results:  
(regression in 1.7.2) The table content is not updated

Expected Results:  
After inserting new pictures in step 2 and OKing the dialogue I expect to see
the new pictures in the table inside the mail composer.

As "send as new" is a major feature for me so the severity is major also.

Comment 1

[Markus Merz]

I am doing it with JPEGs but the testcase is valid.

Comment 2

[Frank Wein [:mcsmurf]]

When did this regress?

Comment 3

[Markus Merz]

(In reply to comment #2)
> When did this regress?
I remember it working fine in 1.7.1. Directly after updating to 1.7.2 I had to
do such a newsletter and saw it the first time.
Can you confirm the bug?

Comment 4

[Frank Wein [:mcsmurf]]

No, but are you sure it appeared from 1.7.1 from 1.7.2? Have you installed in a
clean folder? 1.7.2 was a bugfix release with only four security fixes and
nothing else. So unlikely that this bug was intruced between 1.7.1 and 1.7.2

Comment 5

[Markus Merz]

(In reply to comment #4)
> No, but are you sure it appeared from 1.7.1 from 1.7.2? Have you installed in a
> clean folder? 1.7.2 was a bugfix release with only four security fixes and
> nothing else. So unlikely that this bug was intruced between 1.7.1 and 1.7.2

I am doing these newsletters between two and three times a week. So, I am pretty
sure about the regression.
I did install 1.7.2 in the 1.7.1 folder (no 3d party extensions).
Did you check the testcase? Before opening this bug I checked the testcase and
real life examples a couple of times and the bug is reproducable. What is your
result?

Comment 6

[Frank Wein [:mcsmurf]]

Yes i see the bug with a current cvs trunk build on win2k (both th Testcase and
the Steps to reproduce).

Comment 7

[Markus Merz]

So the 1st thing I did this morning is a clean install into an empty folder (no
plugins or any 3d party extensions) with
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.2) Gecko/20040803
and performed/checked the testcase.

I still can confirm the bug. The presentation in Mail/Composer while composing
is NOT updated. The mail is sent correctly.

Because the bug is confirmed twice now I am asking for status "confirmed" and
flagged it 1.7.3? for QA.

Comment 8

[Markus Merz]

Attachment: testcase - steps and source code to reproduce bug 254880

10.8.04 The testcase was already confirmed twice

Comment 9

[Asa Dotzler [:asa]]

1.7.5 has shipped. Moving request to 1.7.6.

Comment 10

[Daniel Veditz [:dveditz]]

Confirming based on comment 6, but not blocking 1.7.6 --drivers

Comment 11

[(not reading, please use [e-mail] instead)]

sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.

Comment 12

[buovjaga]

No problem anymore.

Insert - HTML to insert the table, though now changed to reflect current logo:

<table align="center" border="1" cellpadding="2" cellspacing="2"
width="85%">
<tbody>
<tr>
<td align="center" valign="top"><img alt=""
src="https://www.mozilla.org/media/img/pebbles/moz-wordmark-dark-reverse.2cbc28bb9895.svg" height="34"
width="34"><br>
</td>
<td align="center" valign="top"><img alt=""
src="https://www.mozilla.org/media/img/pebbles/moz-wordmark-dark-reverse.2cbc28bb9895.svg" height="34"
width="34"></td>
<td align="center" valign="top"><img alt=""
src="https://www.mozilla.org/media/img/pebbles/moz-wordmark-dark-reverse.2cbc28bb9895.svg" height="34"
width="34"></td>
</tr>
<tr>
<td align="center" valign="top"><img alt=""
src="https://www.mozilla.org/media/img/pebbles/moz-wordmark-dark-reverse.2cbc28bb9895.svg" height="34"
width="34"></td>
<td align="center" valign="top"><img alt=""
src="https://www.mozilla.org/media/img/pebbles/moz-wordmark-dark-reverse.2cbc28bb9895.svg" height="34"
width="34"></td>
<td align="center" valign="top"><img alt=""
src="https://www.mozilla.org/media/img/pebbles/moz-wordmark-dark-reverse.2cbc28bb9895.svg" height="34"
width="34"></td>
</tr>
</tbody>
</table>

Then double clicked one logo in edited received mail and replaced with https://www.mozilla.org/media/img/styleguide/identity/firefox/guidelines-logo.7ea045a4e288.png

Refreshes instantly.

Closing.

Thunderbird 52.0.1 (32-bit)
Windows 7 64-bit