Closed
Bug 255245
Opened 21 years ago
Closed 21 years ago
Function.prototype.toSource/.toString show "setrval" instead of "return"
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
VERIFIED
FIXED
People
(Reporter: brendan, Assigned: brendan)
References
()
Details
(Keywords: fixed-aviary1.0, fixed1.7, js1.5)
Attachments
(2 files)
1.19 KB,
patch
|
shaver
:
review+
asa
:
approval-aviary+
asa
:
approval1.7.5+
asa
:
approval1.8a3+
|
Details | Diff | Splinter Review |
2.30 KB,
text/plain
|
Details |
function f() {
try {
} catch (e) {
return false;
}
finally {
}
}
print(f);
Patch immediately.
/be
Assignee | ||
Comment 1•21 years ago
|
||
Assignee | ||
Updated•21 years ago
|
Attachment #155845 -
Flags: review?(shaver)
Updated•21 years ago
|
Attachment #155845 -
Flags: review?(shaver) → review+
Comment 2•21 years ago
|
||
This got to be the fastest bug fix on a module I've ever seen. It was literally,
send a message to jseng, go to the bathroom, return to the office and see the
patch ready! A great THANK YOU Brendan. Do you guys also provide tickets to haven?
Assignee | ||
Comment 3•21 years ago
|
||
Comment on attachment 155845 [details] [diff] [review]
fix
Easy fix, good for all active branches.
/be
Attachment #155845 -
Flags: approval1.8a3?
Attachment #155845 -
Flags: approval1.7.3?
Attachment #155845 -
Flags: approval-aviary?
Comment 4•21 years ago
|
||
Comment on attachment 155845 [details] [diff] [review]
fix
a=asa for checkin to managed branches.
Attachment #155845 -
Flags: approval1.8a3?
Attachment #155845 -
Flags: approval1.8a3+
Attachment #155845 -
Flags: approval1.7.3?
Attachment #155845 -
Flags: approval1.7.3+
Attachment #155845 -
Flags: approval-aviary?
Attachment #155845 -
Flags: approval-aviary+
Assignee | ||
Comment 5•21 years ago
|
||
Fixed on trunk, 1.7 branch, and aviary branch.
/be
Status: NEW → RESOLVED
Closed: 21 years ago
Keywords: fixed-aviary1.0,
fixed1.7
Resolution: --- → FIXED
Comment 6•20 years ago
|
||
thanks to be.
Comment 7•20 years ago
|
||
js1_5/Regress/regress-255245.js checked in with celsoaguiar@hotmail.com added as
contributor.
Updated•20 years ago
|
Flags: testcase+
You need to log in
before you can comment on or make changes to this bug.
Description
•