disallow context menus script setting thing by default

RESOLVED WONTFIX

Status

()

Firefox
General
RESOLVED WONTFIX
14 years ago
5 years ago

People

(Reporter: asa, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

14 years ago
We should set the pref by default so sites can't hijack the context menu. If
whoever is in there doing that would like to make me happy, they could also make
that window resizeable.
(Reporter)

Comment 1

14 years ago
(and maybe we should also just disable raising and lowering of windows and
moving or resizing existing windows too. all of this should help to prevent
spoofing)

Comment 2

14 years ago
Some more annoyances that should be disabled by default:
Bug 186708 resizing windows that have toolbars
Bug 177838 creating non-resizable windows

Comment 3

14 years ago
I agree. That option should be set by default.
Created attachment 180425 [details] [diff] [review]
Patch

Asa, do you want to drive this in?
Assignee: firefox → gavin.sharp
Status: NEW → ASSIGNED
(Reporter)

Updated

13 years ago
Attachment #180425 - Flags: review?(mconnor)
Whiteboard: [patch-r?]
Comment on attachment 180425 [details] [diff] [review]
Patch

This'll have unexpected behaviour with the new prefwindow code.  Disable common
annoyances would then do nothing with this pref, then set it back.  Not
acceptable behaviour.

Jesse, you had something written up about disabling some of these by default
and removing that poorly defined checkbox, care to share?
Attachment #180425 - Flags: review?(mconnor) → review-
Attachment #180425 - Attachment is obsolete: true
OS: Windows XP → All
Hardware: PC → All
Whiteboard: [patch-r?]
Version: unspecified → Trunk
(In reply to comment #5)
> This'll have unexpected behaviour with the new prefwindow code.  Disable common
> annoyances would then do nothing with this pref, then set it back.  Not
> acceptable behaviour.

I think it should be noted that the new pref window already does this for some
other prefs (bug 284079). That doesn't make this the right fix, of course, but
it emphasizes the need for a better general solution.
Comment on attachment 180425 [details] [diff] [review]
Patch

This should work now that the prefs UI was redone.
Attachment #180425 - Attachment is obsolete: false
Attachment #180425 - Flags: review- → review?
Attachment #180425 - Flags: review? → review?(mconnor)
Attachment #180425 - Flags: review?(mconnor)
See bug 299424 comment 7.
Assignee: gavin.sharp → nobody
Status: ASSIGNED → NEW
So the patch can now be reviewed again?
Many sites now depend on this behavior, for example Google Docs provides their own context menu that is specific to the workflow/actions of the application. Changing this will break those sites.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.