255326 - commandglue.js method IsSpecialFolder always says sub-folders of inbox are "special"

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[David :Bienvenu]

IsSpecialFolder() tells us that any sub-folder of the INBOX is an inbox folder,
which means we never close the summary files for cyrus/courier servers, because
we think they're all the INBOX (assuming you haven't set the online dir to INBOX.) 

IsSpecialFolder does this to detect if a folder is a sub-folder of the trash,
but it shouldn't do it for the INBOX.

Comment 1

[David :Bienvenu]

Attachment: proposed fix

add a parameter to IsSpecialFolder, deep, that checks sub-folders, and change
callers. All callers except for INBOX pass true for deep, currently, and we
pass false for INBOX, so that we won't say sub-folders of the inbox are the
inbox!

Comment 2

[David :Bienvenu]

Attachment: better fix

I've renamed the "deep" var to checkancestors, which is a more accurate name,
and simplified the IsSpecialFolder method.

Comment 3

[Scott MacGregor]

Comment on attachment 155936 [details] [diff] [review]
better fix

you might need to change mail\searchBar.js too.

Comment 4

[David :Bienvenu]

thx, good catch, it was in my tree, but I pruned it out accidentally from the
diffs file when editing out the non-relevant diffs...:-(

Comment 5

[David :Bienvenu]

fix checked in.

Comment 6

[[e-mail]]

It hardly seems worth having a deep parameter to IsSpecialFolder - just use
msgFolder.flags & MSG_FOLDER_FLAG_INBOX (or whatever) instead.