Help item "For Internet Explorer Users" should be hidden on OS/2 and Linux

VERIFIED FIXED

Status

SeaMonkey
Help Documentation
VERIFIED FIXED
13 years ago
11 years ago

People

(Reporter: Peter Weilbacher, Assigned: R.J. Keller)

Tracking

({fixed-seamonkey1.0.1, fixed-seamonkey1.1a})

Trunk
x86
Other
fixed-seamonkey1.0.1, fixed-seamonkey1.1a

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 7 obsolete attachments)

(Reporter)

Description

13 years ago
Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.8a3) Gecko/20040811
and
Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.7.2) Gecko/20040814 Firefox/0.9.1+

This has already happened on Unix platforms for Firefox (see bug 214102). OS/2
has never had an Internet Explorer, so I think the same menu item and help
contents should be hidden on OS/2, too.
I will try to get a patch uploaded for both aviary branch and trunk following
the abovementioned bug over the weekend.

Comment 1

13 years ago
What a stupid patch that was.

Just change that line to #ifdef XP_WIN - since XP_UNIX is defined for Mac, this
wasn't showing up on Mac.

This patch only broke OS/2. 

Woohoo!
(Reporter)

Comment 2

13 years ago
Created attachment 156209 [details] [diff] [review]
Enable Help->IEUsers menu item for Win and Mac only

Yes, although I guess it is supposed to show up on MacOSX, because the IEHelp
says "Note: This information applies to Mozilla Firefox for Windows and Mac
OS."

I guess there is no way to exclude this part of the help completely, the
#ifdefs of the original patch were obviously backed out since then because of
build breaks.

This patch enables the _menu item_ for Win and Mac but does nothing to any
other files. It has the desired effect on OS/2.
(Reporter)

Comment 3

13 years ago
Created attachment 156217 [details] [diff] [review]
Fix for Seamonkey on the trunk

This is basically the same fix for Seamonkey, but in the meantime I found out
how to enable the preprocessor for the help-toc.rdf file so that the IEUsers
help does not show up at all on platforms other than Win and Mac. The file
forieusers.xhtml is still packaged, though.
(Assignee)

Comment 4

13 years ago
Comment on attachment 156209 [details] [diff] [review]
Enable Help->IEUsers menu item for Win and Mac only

Neil, can you review this? I don't know if hixie's preprocessor supports
#if defined(XP_WIN) || defined(XP_MACOSX)

If so, then we should use that. It's more than likely that it isn't supported,
however.
Attachment #156209 - Flags: review?(neil.parkwaycc.co.uk)

Comment 5

13 years ago
(In reply to comment #4)
> (From update of attachment 156209 [details] [diff] [review])
> I don't know if hixie's preprocessor supports
> #if defined(XP_WIN) || defined(XP_MACOSX)

Nope, the XUL preprocessor doesn't support that.

Should the firefox patch be updated to preprocess the help ROC rdf?

Comment 6

13 years ago
Comment on attachment 156217 [details] [diff] [review]
Fix for Seamonkey on the trunk

I don't know how keen mkaply is to get this menu item removed in OS2 builds but
Internet Explorer versions were created for Solaris and HP-UX.
Attachment #156217 - Flags: review-

Comment 7

13 years ago
Both those platforms define XP_UNIX, so they wouldn't have had this item anyway.

We should simply change the item to keep the old behavior and remove it on OS/2.

Updated

13 years ago
Attachment #156209 - Flags: review?(neil.parkwaycc.co.uk)

Comment 8

13 years ago
Created attachment 156262 [details] [diff] [review]
Simple fix

Just don't add the menu for OS/2.
(Assignee)

Comment 9

13 years ago
BTW, help TOC cannot be preprocessed for locale reasons.
shouldn't this menu item be removed for Linux as well?

Comment 11

13 years ago
(In reply to comment #10)
> shouldn't this menu item be removed for Linux as well?

It already is
(In reply to comment #11) 
> It already is

should have clarified my question: I still see this menu item with a Linux trunk
build (custom install with all components, fwiw). using 2004081608-trunk (1.8a3
seamonkey) on fedora core 2. was the fix not yet checked in on the trunk?

Comment 13

13 years ago
I don't think anything has been done trunk related yet.
Flags: blocking1.8a4?
OS: OS/2 → other
Summary: Help item "For Internet Explorer Users" should be hidden on OS/2 → Help item "For Internet Explorer Users" should be hidden on OS/2 and Linux
(Reporter)

Comment 14

13 years ago
(In reply to comment #9)
> BTW, help TOC cannot be preprocessed for locale reasons.

Please explain. What is the problem with locales? Can the translators not add
the #ifdefs there?
(Reporter)

Updated

13 years ago
Attachment #156217 - Attachment is obsolete: true
(Reporter)

Updated

13 years ago
Attachment #156209 - Attachment is obsolete: true
(Reporter)

Comment 15

13 years ago
Created attachment 156305 [details] [diff] [review]
Simple fix for Seamonkey

The simple fix obviously has better chances to make it into the tree...
(Assignee)

Comment 16

13 years ago
(In reply to comment #14)
> (In reply to comment #9)
> > BTW, help TOC cannot be preprocessed for locale reasons.
> 
> Please explain. What is the problem with locales? Can the translators not add
> the #ifdefs there?

Localizers translate based on the contents of the locale directories in the JAR
files. If they are inconsistent, they'll be forced to distribute 3 JARs, which
would be unreasonable. We have workaround for the HTML (class="win", etc.) but
nothing yet for TOC.
(Assignee)

Comment 17

13 years ago
Created attachment 156340 [details] [diff] [review]
Patch - no duplicate code.
Attachment #156262 - Attachment is obsolete: true
Attachment #156305 - Attachment is obsolete: true
(Assignee)

Updated

13 years ago
Attachment #156340 - Flags: review?(neil.parkwaycc.co.uk)
(Reporter)

Comment 18

13 years ago
R.J., clever idea to use the extra variable. But you need to move that #endif 

+#ifdef DISPLAY_IE_USERS_HELP_MENU_ITEM
     <menuitem label="&helpForIEUsers.label;"
       accesskey="&helpForIEUsers.accesskey;"
       position="2"
       oncommand="openHelp('ieusers');" />
   </menupopup>
+#endif

up by one line.

Comment 19

13 years ago
Comment on attachment 156340 [details] [diff] [review]
Patch - no duplicate code.

The help text supports IE users on Windows, Mac, Solaris and HP-UX so the menu
item should too.
Attachment #156340 - Flags: review?(neil.parkwaycc.co.uk) → review-

Comment 20

13 years ago
I'm just going to add an #ifndef XP_OS2 inside that block for now if that's OK.

Comment 21

13 years ago
I checked in a Firefox fix.

This still needs some trunk lovin'.

We should probably just use the same think as Firefox  on trunk.
(Assignee)

Updated

13 years ago
Assignee: rlk → neil.parkwaycc.co.uk

Updated

13 years ago
Flags: blocking1.8a4?
(Assignee)

Comment 22

13 years ago
--> me

Hoping to get this one in soon.
Assignee: neil.parkwaycc.co.uk → rj.keller
(Assignee)

Comment 23

13 years ago
Created attachment 161990 [details] [diff] [review]
Patch - w/ solaris, OS2, and HP-UX display added
Attachment #156340 - Attachment is obsolete: true

Comment 24

13 years ago
Actually OS/2 doesn't want the item.
(Assignee)

Updated

13 years ago
Attachment #161990 - Flags: review?(neil.parkwaycc.co.uk)
(Assignee)

Comment 25

13 years ago
Created attachment 161995 [details] [diff] [review]
Patch - real version

Had some confusion and got it cleared up on IRC. This should be the real one.
Attachment #161990 - Attachment is obsolete: true
(Assignee)

Updated

13 years ago
Attachment #161995 - Flags: review?(neil.parkwaycc.co.uk)
(Assignee)

Updated

13 years ago
Attachment #161990 - Flags: review?(neil.parkwaycc.co.uk)
Product: Browser → Seamonkey
(Reporter)

Comment 26

12 years ago
Nothing happened here in a long time, but the patch is still fine for the
current trunk and not too large for a quick review. Any chance to get this in
soon, or do you need to find someone to build on Solaris and HP-UX first?
(Reporter)

Comment 27

12 years ago
Created attachment 201927 [details] [diff] [review]
Update for bitrot (Checked in trunk, branch 1.8 & 1.8.0)

I would still like to see this get into SeaMonkey, always having to build this into my unofficial OS/2 releases is getting annoying...
Attachment #161995 - Attachment is obsolete: true
Attachment #201927 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #201927 - Flags: review?
Attachment #161995 - Flags: review?(neil.parkwaycc.co.uk)
(Reporter)

Updated

12 years ago
Attachment #201927 - Flags: review? → review?(iann_bugzilla)

Updated

12 years ago
Attachment #201927 - Flags: review?(iann_bugzilla) → review+

Comment 28

12 years ago
(In reply to comment #27)
> I would still like to see this get into SeaMonkey, always having to build this
> into my unofficial OS/2 releases is getting annoying...
> 
I agree, Peter. For the UI, it creates unnecessary clutter in the Help menu. Frankly, I'd be happy with M$ putting a help menu item in IE: "Help for Mozilla Users." That would really be helpful for those times when I need to do support on Windows machines running IE...at least, before I install SeaMonkey on them. ;-)

Lewis

Comment 29

12 years ago
Quick userChrome.css hack to at least hide the blasted thing:

/* Hide annoying IE help item */
menuitem[label="For Internet Explorer Users"] {
  display: none !important;
  }

Lewis

Updated

12 years ago
Attachment #201927 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
(Reporter)

Comment 30

12 years ago
Thanks for the reviews. Could someone please get this into the trunk? And which flag do I have to set to ask for approval for SeaMonkey 1.0x?
(Reporter)

Comment 31

12 years ago
Comment on attachment 201927 [details] [diff] [review]
Update for bitrot (Checked in trunk, branch 1.8 & 1.8.0)

Checkin reminder, please: anyone?

Would also be great to see this in SeaMonkey 1.0 or at least 1.1.
Attachment #201927 - Flags: approval-seamonkey1.1?
Attachment #201927 - Flags: approval-seamonkey1.0?

Comment 32

12 years ago
Comment on attachment 201927 [details] [diff] [review]
Update for bitrot (Checked in trunk, branch 1.8 & 1.8.0)

a=mw for 1.1, first a= from me for 1.0 (second one still needed) given that it's been tested on all tier-1 platforms on trunk and/or 1.1 before it goes into 1.0
Attachment #201927 - Flags: approval-seamonkey1.1? → approval-seamonkey1.1+

Comment 33

12 years ago
Comment on attachment 201927 [details] [diff] [review]
Update for bitrot (Checked in trunk, branch 1.8 & 1.8.0)

a=me second needed one from SM1.0
Attachment #201927 - Flags: approval-seamonkey1.0? → approval-seamonkey1.0+
(Assignee)

Comment 34

12 years ago
Fix checked in on the trunk (which I assume is Seamonkey1.1). I have no clue what branch Seamonkey 1.0 is on so if someone tells me, I'll check it into there too.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Reporter)

Comment 35

12 years ago
Thanks R.J. Trunk is correct for now, SeaMonkey 1.0 would be MOZILLA_1_8_0_BRANCH and SeaMonkey 1.1 MOZILLA_1_8_BRANCH, but give me some time to test on the trunk.
(Assignee)

Comment 36

12 years ago
oh ok, I assumed Seamonkey 1.1 was the trunk :). I've ran this code previously with no problem so I doubt there'd be an issue.

Tell me when and I'll check it into those branches.
(Reporter)

Comment 37

12 years ago
R.J., because I have some problems with sending email I am not sure if the one I sent to you arrived, so I repeat it here. I think you can check in to both these branches now. I tested with Windows and Linux and didn't see any complaints about MacOSX.
(Reporter)

Updated

11 years ago
Attachment #201927 - Flags: approval-seamonkey1.0.1?

Comment 38

11 years ago
Comment on attachment 201927 [details] [diff] [review]
Update for bitrot (Checked in trunk, branch 1.8 & 1.8.0)

forwarding a+ from 1.0, this is nice very-low-risk polish.
Attachment #201927 - Flags: approval-seamonkey1.0.1? → approval-seamonkey1.0.1+

Comment 39

11 years ago
Comment on attachment 201927 [details] [diff] [review]
Update for bitrot (Checked in trunk, branch 1.8 & 1.8.0)

Checking in (branch 1.8)
jar.mn;
new revision: 1.66.8.1; previous revision: 1.66
content/helpMenuOverlay.xul;
new revision: 1.14.4.1; previous revision: 1.14
done
Checking in (branch 1.8.0)
jar.mn;
new revision: 1.66.16.1; previous revision: 1.66
content/helpMenuOverlay.xul;
new revision: 1.14.12.1; previous revision: 1.14
done
Attachment #201927 - Attachment description: Update for bitrot → Update for bitrot (Checked in trunk, branch 1.8 & 1.8.0)

Updated

11 years ago
Keywords: fixed-seamonkey1.0.1, fixed-seamonkey1.1a
(Reporter)

Comment 40

11 years ago
Thanks everyone!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.